[GitHub] [kafka] hudeqi commented on pull request #13926: KAFKA-15129;[2/N] Remove metrics in GroupMetadataManager when shutdown

["hudeqi (via GitHub)" <gi...@apache.org>]

hudeqi commented on PR #13926:
URL: https://github.com/apache/kafka/pull/13926#issuecomment-1614782255

   Combined with the explanation of https://github.com/apache/kafka/pull/3506#discussion_r128589927 and the results of my actual test, I think this is the case: All unit tests in `GroupMetadataManagerTest` involve many times of "new GroupMetadataManager" behavior , since "calls newGauge" is a global registry, it will affect the subsequent metric verification (`testMetrics()` method) in multiple unit tests.
   I remember that I replaced "recreateGauge" directly before mentioning this PR. The unit test failed. Now because I added "removeMetrics()" to "groupMetadataManager.shutdown()"(also in@AfterEach), it will be the same as "recreateGauge" effect. @clolov @dajac 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org