You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "cryptoe (via GitHub)" <gi...@apache.org> on 2023/03/04 01:02:48 UTC
[GitHub] [druid] cryptoe opened a new pull request, #13882: Adding forbidden api for Properties#getOrDefault()
cryptoe opened a new pull request, #13882:
URL: https://github.com/apache/druid/pull/13882
<!-- Thanks for trying to help us make Apache Druid be the best it can be! Please fill out as much of the following information as is possible (where relevant, and remove it when irrelevant) to help make the intention and scope of this PR clear in order to ease review. -->
<!-- Please read the doc for contribution (https://github.com/apache/druid/blob/master/CONTRIBUTING.md) before making this PR. Also, once you open a PR, please _avoid using force pushes and rebasing_ since these make it difficult for reviewers to see what you've changed in response to their reviews. See [the 'If your pull request shows conflicts with master' section](https://github.com/apache/druid/blob/master/CONTRIBUTING.md#if-your-pull-request-shows-conflicts-with-master) for more details. -->
Added a check so that we donot call Propeties#getOrDefault accidentally. I donot think we would have a legit use case of calling this API ever. Motivation for this change: https://github.com/apache/druid/pull/13881 .
`Properties#getOrDefault` method does not check the default map for values where as` Properties#getProperty()` does.
This PR has:
- [x] been self-reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] cryptoe commented on pull request #13882: Adding forbidden api for Properties#get() and Properties#getOrDefault()
Posted by "cryptoe (via GitHub)" <gi...@apache.org>.
cryptoe commented on PR #13882:
URL: https://github.com/apache/druid/pull/13882#issuecomment-1462234354
> This seems to not work in java 8, I see:
>
> ```
> [ERROR] Failed to execute goal de.thetaphi:forbiddenapis:3.2:check (compile) on project druid-sql: Parsing signatures failed: Method not found while parsing signature: java.util.Properties#get(java.lang.Object) -> [Help 1]
> ```
>
> There are no problems with java 11 or 17.
Raised a PR here : https://github.com/apache/druid/pull/13910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] cryptoe merged pull request #13882: Adding forbidden api for Properties#get() and Properties#getOrDefault()
Posted by "cryptoe (via GitHub)" <gi...@apache.org>.
cryptoe merged PR #13882:
URL: https://github.com/apache/druid/pull/13882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on pull request #13882: Adding forbidden api for Properties#get() and Properties#getOrDefault()
Posted by "clintropolis (via GitHub)" <gi...@apache.org>.
clintropolis commented on PR #13882:
URL: https://github.com/apache/druid/pull/13882#issuecomment-1460963667
This seems to not work in java 8, I see:
```
[ERROR] Failed to execute goal de.thetaphi:forbiddenapis:3.2:check (compile) on project druid-sql: Parsing signatures failed: Method not found while parsing signature: java.util.Properties#get(java.lang.Object) -> [Help 1]
```
There are no problems with java 11 or 17.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org