You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by icexelloss <gi...@git.apache.org> on 2017/12/04 18:41:59 UTC

[GitHub] spark pull request #19852: [SPARK-22655][PySpark] Throw exception rather tha...

Github user icexelloss commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19852#discussion_r154737303
  
    --- Diff: core/src/main/scala/org/apache/spark/api/python/PythonRunner.scala ---
    @@ -319,7 +319,7 @@ private[spark] abstract class BasePythonRunner[IN, OUT](
     
           case e: Exception if env.isStopped =>
             logDebug("Exception thrown after context is stopped", e)
    -        null.asInstanceOf[OUT]  // exit silently
    +        throw new SparkException("Spark session has been stopped", e)
    --- End diff --
    
    @cloud-fan Thoughts?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org