You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/08/27 18:59:58 UTC
[GitHub] [netbeans] BradWalker opened a new pull request, #4555: Cleanup a bunch of raw type error msgs related to TreeSet.
BradWalker opened a new pull request, #4555:
URL: https://github.com/apache/netbeans/pull/4555
Cleanup a bunch of raw type error messages. Issues like these..
[repeat] /home/bwalker/src/netbeans/enterprise/web.core.syntax/src/org/netbeans/modules/web/core/syntax/JspSyntaxSupport.java:512: warning: [unchecked] unchecked call to addAll(Collection<? extends E>) as a member of the raw type TreeSet
[repeat] ts.addAll(mapper.keySet());
[repeat] ^
[repeat] where E is a type-variable:
[repeat] E extends Object declared in class TreeSet
---
**^Add meaningful description above**
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
- are all your own work, and you have the right to contribute them.
- are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).
Please make sure (eg. `git log`) that all commits have a valid name and email address for you in the Author field.
If you're a first time contributor, see the Contributing guidelines for more information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on pull request #4555: Cleanup a bunch of raw type error msgs related to TreeSet.
Posted by GitBox <gi...@apache.org>.
BradWalker commented on PR #4555:
URL: https://github.com/apache/netbeans/pull/4555#issuecomment-1238433291
>
> then please ask next time. We can fix this. But not once its in master. There is no hurry in getting cleanup PRs in. Just speak up and say that something is wrong with the branch and I am sure someone will be willing to look at it.
Completely understand. Thank you for the well reasoned reply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4555: Cleanup a bunch of raw type error msgs related to TreeSet.
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4555:
URL: https://github.com/apache/netbeans/pull/4555#issuecomment-1237911395
please avoid integrating someone else' commits via a PR, this can cause all kinds of issues (and is confusing in the log).
Also, you don't have to create a new PR if the branch has issues, simply force push into the PR branch to repair things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a diff in pull request #4555: Cleanup a bunch of raw type error msgs related to TreeSet.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on code in PR #4555:
URL: https://github.com/apache/netbeans/pull/4555#discussion_r957110059
##########
platform/openide.filesystems/src/org/openide/filesystems/DefaultAttributes.java:
##########
@@ -1036,7 +1036,7 @@ protected String[] getAllowedAttrs() {
*/
public void writeToXML(PrintWriter pw) /*throws IOException */ {
// list of names
- Iterator<String> it = new TreeSet(keySet()).iterator();
+ Iterator<String> it = new TreeSet<String>(keySet()).iterator();
Review Comment:
Why not diamond?
##########
enterprise/web.jspparser/src/org/netbeans/modules/web/jsps/parserapi/PageInfo.java:
##########
@@ -635,7 +635,7 @@ public boolean isELIgnored() {
// added in NetBeans
- public Map getTagLibraries() {
+ public Map<String, TagLibraryInfo> getTagLibraries() {
Review Comment:
Changing public API (adding generics) - but looks sane to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker closed pull request #4555: Cleanup a bunch of raw type error msgs related to TreeSet.
Posted by GitBox <gi...@apache.org>.
BradWalker closed pull request #4555: Cleanup a bunch of raw type error msgs related to TreeSet.
URL: https://github.com/apache/netbeans/pull/4555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #4555: Cleanup a bunch of raw type error msgs related to TreeSet.
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #4555:
URL: https://github.com/apache/netbeans/pull/4555#discussion_r960117646
##########
ide/xml.catalog.ui/src/org/netbeans/modules/xml/catalog/CatalogRootNode.java:
##########
@@ -172,7 +172,7 @@ public HelpCtx getHelpCtx() {
private static class RootChildren extends Children.Keys implements Comparator, PropertyChangeListener {
/** Contains CatalogReader instances. */
- private final TreeSet keys = new TreeSet(this);
+ private final Set keys = new TreeSet<>(this);
Review Comment:
I think this can be `Set<CatalogReader>` as the comment states if the item is cast to `CatalogReader` further down in `createKeys(..)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on pull request #4555: Cleanup a bunch of raw type error msgs related to TreeSet.
Posted by GitBox <gi...@apache.org>.
BradWalker commented on PR #4555:
URL: https://github.com/apache/netbeans/pull/4555#issuecomment-1238211031
> please avoid integrating someone else's commits via a PR, this can cause all kinds of issues (and is confusing in the log).
>
> Also, you don't have to create a new PR if the branch has issues, simply force push into the PR branch to repair things.
I agree with your comments.. I'm really at a loss of how that happened because my local repo that I pushed did not have any changes from others. I made sure of this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4555: Cleanup a bunch of raw type error msgs related to TreeSet.
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4555:
URL: https://github.com/apache/netbeans/pull/4555#issuecomment-1238352125
> > please avoid integrating someone else's commits via a PR, this can cause all kinds of issues (and is confusing in the log).
> > Also, you don't have to create a new PR if the branch has issues, simply force push into the PR branch to repair things.
>
> I agree with your comments.. I'm really at a loss of how that happened because my local repo that I pushed did not have any changes from others. I made sure of this!
then please ask next time. We can fix this. But not once its in master. There is no hurry in getting cleanup PRs in. Just speak up and say that something is wrong with the branch and I am sure someone will be willing to look at it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a diff in pull request #4555: Cleanup a bunch of raw type error msgs related to TreeSet.
Posted by GitBox <gi...@apache.org>.
BradWalker commented on code in PR #4555:
URL: https://github.com/apache/netbeans/pull/4555#discussion_r962359430
##########
ide/xml.catalog.ui/src/org/netbeans/modules/xml/catalog/CatalogRootNode.java:
##########
@@ -172,7 +172,7 @@ public HelpCtx getHelpCtx() {
private static class RootChildren extends Children.Keys implements Comparator, PropertyChangeListener {
/** Contains CatalogReader instances. */
- private final TreeSet keys = new TreeSet(this);
+ private final Set keys = new TreeSet<>(this);
Review Comment:
Done..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a diff in pull request #4555: Cleanup a bunch of raw type error msgs related to TreeSet.
Posted by GitBox <gi...@apache.org>.
BradWalker commented on code in PR #4555:
URL: https://github.com/apache/netbeans/pull/4555#discussion_r962359483
##########
platform/openide.filesystems/src/org/openide/filesystems/DefaultAttributes.java:
##########
@@ -1036,7 +1036,7 @@ protected String[] getAllowedAttrs() {
*/
public void writeToXML(PrintWriter pw) /*throws IOException */ {
// list of names
- Iterator<String> it = new TreeSet(keySet()).iterator();
+ Iterator<String> it = new TreeSet<String>(keySet()).iterator();
Review Comment:
Done..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists