You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@cocoon.apache.org by jo...@apache.org on 2004/11/23 14:19:55 UTC

svn commit: r106296 - /cocoon/trunk/src/blocks/forms/java/org/apache/cocoon/forms/datatype/DefaultSelectionListBuilder.java

Author: joerg
Date: Tue Nov 23 05:19:52 2004
New Revision: 106296

Modified:
   cocoon/trunk/src/blocks/forms/java/org/apache/cocoon/forms/datatype/DefaultSelectionListBuilder.java
Log:
fixed possible NPE

Modified: cocoon/trunk/src/blocks/forms/java/org/apache/cocoon/forms/datatype/DefaultSelectionListBuilder.java
Url: http://svn.apache.org/viewcvs/cocoon/trunk/src/blocks/forms/java/org/apache/cocoon/forms/datatype/DefaultSelectionListBuilder.java?view=diff&rev=106296&p1=cocoon/trunk/src/blocks/forms/java/org/apache/cocoon/forms/datatype/DefaultSelectionListBuilder.java&r1=106295&p2=cocoon/trunk/src/blocks/forms/java/org/apache/cocoon/forms/datatype/DefaultSelectionListBuilder.java&r2=106296
==============================================================================
--- cocoon/trunk/src/blocks/forms/java/org/apache/cocoon/forms/datatype/DefaultSelectionListBuilder.java	(original)
+++ cocoon/trunk/src/blocks/forms/java/org/apache/cocoon/forms/datatype/DefaultSelectionListBuilder.java	Tue Nov 23 05:19:52 2004
@@ -137,10 +137,10 @@
 
             return selectionListElement;
         } finally {
-            if (source != null) {
-                resolver.release(source);
-            }
             if (resolver != null) {
+                if (source != null) {
+                    resolver.release(source);
+                }
                 serviceManager.release(resolver);
             }
         }