You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by on...@apache.org on 2017/01/05 07:16:27 UTC
svn commit: r1777423 -
/poi/trunk/src/scratchpad/testcases/org/apache/poi/hsmf/TestFileWithAttachmentsRead.java
Author: onealj
Date: Thu Jan 5 07:16:27 2017
New Revision: 1777423
URL: http://svn.apache.org/viewvc?rev=1777423&view=rev
Log:
junit improvements:
assertEquals(null, ...) -> assertNull(...)
attachment.getAttachFileName().toString() -> attachment.getAttachFileName().getValue()
Modified:
poi/trunk/src/scratchpad/testcases/org/apache/poi/hsmf/TestFileWithAttachmentsRead.java
Modified: poi/trunk/src/scratchpad/testcases/org/apache/poi/hsmf/TestFileWithAttachmentsRead.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/testcases/org/apache/poi/hsmf/TestFileWithAttachmentsRead.java?rev=1777423&r1=1777422&r2=1777423&view=diff
==============================================================================
--- poi/trunk/src/scratchpad/testcases/org/apache/poi/hsmf/TestFileWithAttachmentsRead.java (original)
+++ poi/trunk/src/scratchpad/testcases/org/apache/poi/hsmf/TestFileWithAttachmentsRead.java Thu Jan 5 07:16:27 2017
@@ -81,17 +81,17 @@ public class TestFileWithAttachmentsRead
// Now check in detail
attachment = twoSimpleAttachments.getAttachmentFiles()[0];
- assertEquals("TEST-U~1.DOC", attachment.getAttachFileName().toString());
- assertEquals("test-unicode.doc", attachment.getAttachLongFileName().toString());
+ assertEquals("TEST-U~1.DOC", attachment.getAttachFileName().getValue());
+ assertEquals("test-unicode.doc", attachment.getAttachLongFileName().getValue());
assertEquals(".doc", attachment.getAttachExtension().getValue());
- assertEquals(null, attachment.getAttachMimeTag());
+ assertNull(attachment.getAttachMimeTag());
assertEquals(24064, attachment.getAttachData().getValue().length);
attachment = twoSimpleAttachments.getAttachmentFiles()[1];
- assertEquals("pj1.txt", attachment.getAttachFileName().toString());
- assertEquals("pj1.txt", attachment.getAttachLongFileName().toString());
+ assertEquals("pj1.txt", attachment.getAttachFileName().getValue());
+ assertEquals("pj1.txt", attachment.getAttachLongFileName().getValue());
assertEquals(".txt", attachment.getAttachExtension().getValue());
- assertEquals(null, attachment.getAttachMimeTag());
+ assertNull(attachment.getAttachMimeTag());
assertEquals(89, attachment.getAttachData().getValue().length);
}
@@ -106,20 +106,20 @@ public class TestFileWithAttachmentsRead
// Second is a PDF
attachment = pdfMsgAttachments.getAttachmentFiles()[1];
- assertEquals("smbprn~1.pdf", attachment.getAttachFileName().toString());
- assertEquals("smbprn.00009008.KdcPjl.pdf", attachment.getAttachLongFileName().toString());
+ assertEquals("smbprn~1.pdf", attachment.getAttachFileName().getValue());
+ assertEquals("smbprn.00009008.KdcPjl.pdf", attachment.getAttachLongFileName().getValue());
assertEquals(".pdf", attachment.getAttachExtension().getValue());
- assertEquals(null, attachment.getAttachMimeTag());
- assertEquals(null, attachment.getAttachmentDirectory());
+ assertNull(attachment.getAttachMimeTag());
+ assertNull(attachment.getAttachmentDirectory());
assertEquals(13539, attachment.getAttachData().getValue().length);
// First in a nested message
attachment = pdfMsgAttachments.getAttachmentFiles()[0];
- assertEquals("Test Attachment", attachment.getAttachFileName().toString());
- assertEquals(null, attachment.getAttachLongFileName());
- assertEquals(null, attachment.getAttachExtension());
- assertEquals(null, attachment.getAttachMimeTag());
- assertEquals(null, attachment.getAttachData());
+ assertEquals("Test Attachment", attachment.getAttachFileName().getValue());
+ assertNull(attachment.getAttachLongFileName());
+ assertNull(attachment.getAttachExtension());
+ assertNull(attachment.getAttachMimeTag());
+ assertNull(attachment.getAttachData());
assertNotNull(attachment.getAttachmentDirectory());
// Check we can see some bits of it
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org