You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/02/22 20:27:58 UTC

[GitHub] [superset] etr2460 commented on a change in pull request #18852: fix(dashboard): incorrect chart error with slow dataset api request

etr2460 commented on a change in pull request #18852:
URL: https://github.com/apache/superset/pull/18852#discussion_r812329924



##########
File path: superset-frontend/src/chart/Chart.jsx
##########
@@ -220,6 +220,7 @@ class Chart extends React.PureComponent {
 
     return (
       <ChartErrorMessage
+        key={chartId}

Review comment:
       was this needed to fix the issue too? i'm surprised that setting the key to the id would cause a rerender since i wouldn't expect the id to ever change




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org