You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Doug Cutting (JIRA)" <ji...@apache.org> on 2009/11/12 20:43:39 UTC
[jira] Updated: (AVRO-171) Protocol Introspection can produce
invalid forward references
[ https://issues.apache.org/jira/browse/AVRO-171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated AVRO-171:
------------------------------
Attachment: AVRO-171.patch
Here's a patch that fixes this and AVRO-170, including a unit test.
> Protocol Introspection can produce invalid forward references
> -------------------------------------------------------------
>
> Key: AVRO-171
> URL: https://issues.apache.org/jira/browse/AVRO-171
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.2.0
> Environment: java
> Reporter: Mr Fish
> Attachments: AVRO-171.patch
>
>
> Take a look at this code which is what happens in the SpecificResponder handshake.
> // server side
> final Protocol protocol = ReflectData.get().getProtocol(MyServiceIface.class);
> final String string = protocol.toString();
> // client side
> Protocol.parse(string);
> If you have a compound object made of
> class A {
> B1 b1;
> B2 b2;
> }
> class B1 {
> X x;
> }
> class B2 {
> X x;
> }
> class X {
> int i;
> }
> Then the types will be built up by RefectData.createSchema()
> A, B1, X, B2
> This is then reversed by RefectData.getProtocol() so B1 has no forward reference
> B2, X, B1, A.
> But this breaks B2
> org.apache.avro.SchemaParseException: Undefined name: "X"
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.