You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/10/20 02:48:49 UTC

[GitHub] [echarts] pissang commented on a change in pull request #15878: fix(axis): fix charts render abnormally when `yAxis.max` is set to be a value less than the min value of the series data.

pissang commented on a change in pull request #15878:
URL: https://github.com/apache/echarts/pull/15878#discussion_r728625823



##########
File path: src/coord/scaleRawExtentInfo.ts
##########
@@ -201,11 +201,6 @@ export class ScaleRawExtentInfo {
         (min == null || !isFinite(min)) && (min = NaN);
         (max == null || !isFinite(max)) && (max = NaN);
 
-        if (min > max) {
-            min = NaN;
-            max = NaN;

Review comment:
       This change looks good in the example. Are there any concerns at the time we adding this logic @100pah 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org