You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/19 10:46:32 UTC

[GitHub] [airflow] YuDorogov opened a new pull request #15428: Fix KEDA Autoscaler connectionFromEnv

YuDorogov opened a new pull request #15428:
URL: https://github.com/apache/airflow/pull/15428


   Set worker container first in containers, move git-sync container to bottom, beacuse KEDA get environment variables(AIRFLOW_CONN_AIRFLOW_DB) from worker container(git-sync container not contain this env variable)
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #15428: Fix KEDA Autoscaler connectionFromEnv

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15428:
URL: https://github.com/apache/airflow/pull/15428#issuecomment-826928021


   The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] YuDorogov edited a comment on pull request #15428: Fix KEDA Autoscaler connectionFromEnv

Posted by GitBox <gi...@apache.org>.
YuDorogov edited a comment on pull request #15428:
URL: https://github.com/apache/airflow/pull/15428#issuecomment-824512356


   If i use git-sync sidecar container with keda autoscaler, git-sync will be [0] in containers array, and not contain connection env's, then KEDA could not get [AIRFLOW_CONN_AIRFLOW_DB](https://github.com/apache/airflow/blob/508cd394bcf8dc1bada8824d52ebff7bb6c86b3b/chart/templates/workers/worker-kedaautoscaler.yaml#L47) variable from git-sync sidecar in worker deployment(git-sync not contain it).
   Resolution: the [worker container](https://github.com/apache/airflow/blob/508cd394bcf8dc1bada8824d52ebff7bb6c86b3b/chart/templates/workers/worker-deployment.yaml#L125) must always be [0] in the container array, because it contain all connection env's


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] YuDorogov edited a comment on pull request #15428: Fix KEDA Autoscaler connectionFromEnv

Posted by GitBox <gi...@apache.org>.
YuDorogov edited a comment on pull request #15428:
URL: https://github.com/apache/airflow/pull/15428#issuecomment-824512356


   If i use git-sync sidecar container with keda autoscaler, git-sync will be 0 in containers array, and not contain connection env's, then KEDA could not get [AIRFLOW_CONN_AIRFLOW_DB](https://github.com/apache/airflow/blob/508cd394bcf8dc1bada8824d52ebff7bb6c86b3b/chart/templates/workers/worker-kedaautoscaler.yaml#L47) variable from git-sync sidecar in worker deployment.
   Resolution: the [worker container](https://github.com/apache/airflow/blob/508cd394bcf8dc1bada8824d52ebff7bb6c86b3b/chart/templates/workers/worker-deployment.yaml#L125) must always be 0 in the container array, because it contain all connection env's


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] YuDorogov edited a comment on pull request #15428: Fix KEDA Autoscaler connectionFromEnv

Posted by GitBox <gi...@apache.org>.
YuDorogov edited a comment on pull request #15428:
URL: https://github.com/apache/airflow/pull/15428#issuecomment-824512356


   If i use git-sync sidecar container with keda autoscaler, git-sync will be 0 in containers array, and not contain connection env's, then KEDA could not get [AIRFLOW_CONN_AIRFLOW_DB](https://github.com/apache/airflow/blob/508cd394bcf8dc1bada8824d52ebff7bb6c86b3b/chart/templates/workers/worker-kedaautoscaler.yaml#L47) variable from git-sync sidecar in worker deployment(git-sync not contain it).
   Resolution: the [worker container](https://github.com/apache/airflow/blob/508cd394bcf8dc1bada8824d52ebff7bb6c86b3b/chart/templates/workers/worker-deployment.yaml#L125) must always be 0 in the container array, because it contain all connection env's


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] YuDorogov closed pull request #15428: Fix KEDA Autoscaler connectionFromEnv

Posted by GitBox <gi...@apache.org>.
YuDorogov closed pull request #15428:
URL: https://github.com/apache/airflow/pull/15428


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] dimberman commented on pull request #15428: Fix KEDA Autoscaler connectionFromEnv

Posted by GitBox <gi...@apache.org>.
dimberman commented on pull request #15428:
URL: https://github.com/apache/airflow/pull/15428#issuecomment-826927597


   @YuDorogov can you please get tests to pass? I can merge when they work.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] dimberman commented on pull request #15428: Fix KEDA Autoscaler connectionFromEnv

Posted by GitBox <gi...@apache.org>.
dimberman commented on pull request #15428:
URL: https://github.com/apache/airflow/pull/15428#issuecomment-828565077


   @YuDorogov what happened? Do you need help cleaning up the history?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] YuDorogov edited a comment on pull request #15428: Fix KEDA Autoscaler connectionFromEnv

Posted by GitBox <gi...@apache.org>.
YuDorogov edited a comment on pull request #15428:
URL: https://github.com/apache/airflow/pull/15428#issuecomment-824512356


   If i use git-sync sidecar container with keda autoscaler, git-sync will be 0 in containers array, and not contain connection env's, then KEDA could not get [AIRFLOW_CONN_AIRFLOW_DB](https://github.com/apache/airflow/blob/508cd394bcf8dc1bada8824d52ebff7bb6c86b3b/chart/templates/workers/worker-kedaautoscaler.yaml#L47) variable from git-sync sidecar in worker deployment


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #15428: Fix KEDA Autoscaler connectionFromEnv

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #15428:
URL: https://github.com/apache/airflow/pull/15428#issuecomment-822371761


   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโ€™s a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
   Apache Airflow is a community-driven project and together we are making it better ๐Ÿš€.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://s.apache.org/airflow-slack
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] YuDorogov commented on pull request #15428: Fix KEDA Autoscaler connectionFromEnv

Posted by GitBox <gi...@apache.org>.
YuDorogov commented on pull request #15428:
URL: https://github.com/apache/airflow/pull/15428#issuecomment-824512356


   If i use git-sync sidecar container with keda autoscaler, git-sync will be 0 in containers array, and not contain connection env's, then KEDA could not get [AIRFLOW_CONN_AIRFLOW_DB](https://github.com/apache/airflow/blob/508cd394bcf8dc1bada8824d52ebff7bb6c86b3b/chart/templates/workers/worker-kedaautoscaler.yaml#L47) variable from git-sync sidecar 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] YuDorogov edited a comment on pull request #15428: Fix KEDA Autoscaler connectionFromEnv

Posted by GitBox <gi...@apache.org>.
YuDorogov edited a comment on pull request #15428:
URL: https://github.com/apache/airflow/pull/15428#issuecomment-824512356


   If i use git-sync sidecar container with keda autoscaler, git-sync will be 0 in containers array, and not contain connection env's, then KEDA could not get [AIRFLOW_CONN_AIRFLOW_DB](https://github.com/apache/airflow/blob/508cd394bcf8dc1bada8824d52ebff7bb6c86b3b/chart/templates/workers/worker-kedaautoscaler.yaml#L47) variable from git-sync sidecar in worker deployment.
   Resolution: the [worker container](https://github.com/apache/airflow/blob/508cd394bcf8dc1bada8824d52ebff7bb6c86b3b/chart/templates/workers/worker-deployment.yaml#L125) must always be 0 in the container array


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on pull request #15428: Fix KEDA Autoscaler connectionFromEnv

Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #15428:
URL: https://github.com/apache/airflow/pull/15428#issuecomment-824413154


   I am not sure I follow, can you add some details please, does changing the order of a list/array matter?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org