You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by avati <gi...@git.apache.org> on 2014/08/01 00:56:10 UTC
[GitHub] spark pull request: SPARK-1812: upgrade dependency to scala-loggin...
GitHub user avati opened a pull request:
https://github.com/apache/spark/pull/1701
SPARK-1812: upgrade dependency to scala-logging 2.1.2
Scala 2.11 packages not available for the current version (1.0.1)
Signed-off-by: Anand Avati <av...@redhat.com>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/avati/spark SPARK-1812-slf4j-2.1.2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/1701.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1701
----
commit 54ecb8dbaebe042819c987b67413bfa87db6c1a2
Author: Anand Avati <av...@redhat.com>
Date: 2014-07-31T22:54:12Z
SPARK-1812: upgrade dependency to scala-logging 2.1.2
Signed-off-by: Anand Avati <av...@redhat.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1812] upgrade dependency to scala-loggi...
Posted by avati <gi...@git.apache.org>.
Github user avati commented on a diff in the pull request:
https://github.com/apache/spark/pull/1701#discussion_r15683518
--- Diff: sql/core/pom.xml ---
@@ -83,6 +83,16 @@
<artifactId>scalacheck_${scala.binary.version}</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.typesafe.scala-logging</groupId>
+ <artifactId>scala-logging-slf4j_${scala.binary.version}</artifactId>
+ <version>2.1.2</version>
+ </dependency>
+ <dependency>
+ <groupId>com.typesafe.scala-logging</groupId>
+ <artifactId>scala-logging-api_${scala.binary.version}</artifactId>
--- End diff --
scalalogging-slf4j-1.0.1 seems to be split into scala-logging-{slf4j,api} for 2.1.2. Previously scalalogging was missing in sql/core pom.xml (usually not a problem unless you do mvn compile within the module)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1812] upgrade dependency to scala-loggi...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1701#issuecomment-50897872
QA tests have started for PR 1701. This patch merges cleanly. <br>View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17676/consoleFull
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1812] upgrade dependency to scala-loggi...
Posted by ScrapCodes <gi...@git.apache.org>.
Github user ScrapCodes commented on the pull request:
https://github.com/apache/spark/pull/1701#issuecomment-50852258
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1812] upgrade dependency to scala-loggi...
Posted by ScrapCodes <gi...@git.apache.org>.
Github user ScrapCodes commented on a diff in the pull request:
https://github.com/apache/spark/pull/1701#discussion_r15683473
--- Diff: sql/core/pom.xml ---
@@ -83,6 +83,16 @@
<artifactId>scalacheck_${scala.binary.version}</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.typesafe.scala-logging</groupId>
+ <artifactId>scala-logging-slf4j_${scala.binary.version}</artifactId>
+ <version>2.1.2</version>
+ </dependency>
+ <dependency>
+ <groupId>com.typesafe.scala-logging</groupId>
+ <artifactId>scala-logging-api_${scala.binary.version}</artifactId>
--- End diff --
Can you explain why we need the second artifact ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1812] upgrade dependency to scala-loggi...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1701#issuecomment-50906624
QA results for PR 1701:<br>- This patch PASSES unit tests.<br>- This patch merges cleanly<br>- This patch adds no public classes<br><br>For more information see test ouptut:<br>https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17676/consoleFull
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1812] upgrade dependency to scala-loggi...
Posted by ScrapCodes <gi...@git.apache.org>.
Github user ScrapCodes commented on the pull request:
https://github.com/apache/spark/pull/1701#issuecomment-50855246
@pwendell Jenkins does not listen to my commands, Can you command it ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1812] upgrade dependency to scala-loggi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1701
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-1812: upgrade dependency to scala-loggin...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1701#issuecomment-50829701
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1812] upgrade dependency to scala-loggi...
Posted by ScrapCodes <gi...@git.apache.org>.
Github user ScrapCodes commented on the pull request:
https://github.com/apache/spark/pull/1701#issuecomment-50857755
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1812] upgrade dependency to scala-loggi...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/1701#issuecomment-50897364
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---