You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Devdeep Singh <de...@citrix.com> on 2013/10/28 12:41:00 UTC

[Merge] hyperv branch to master

Hi,

I would like to merge the support for Hyperv to the master branch. Development for this has been done by Donal, Rajesh, Anshul and I on branch [1]. The feature was proposed for merge earlier [3] but unit tests for hyperv agent code were requested [4].

Checklist:
The development for the feature was earlier done in branch [2] but later moved to [1].
Jira ticket for the feature is here [5].
The FS can be found at [6] and [7].
Unit tests for the feature are available at [8]

This link [7] also provides details of third party libraries used by the plugin including their licenses. No source for these libraries is used, and the binaries are downloaded from their distributors at build time. No proprietary tools are required for the build.  For instance, C# compiled with Mono has been tested. Mono setup details can be found here [9].

[1] https://git-wip-us.apache.org/repos/asf/cloudstack/repo?p=cloudstack.git;a=shortlog;h=refs/heads/hyperv
[2] https://github.com/lafferty/cloudstack/tree/hyperv_plugin
[3] http://markmail.org/message/cm7kdwh6l2ea772e?q=list:org%2Eapache%2Eincubator%2Ecloudstack-%2A+Minimal+Hyperv+plugin
[4] http://markmail.org/message/vxknappvyovhmeyp?q=list:org%2Eapache%2Eincubator%2Ecloudstack-%2A+Minimal+Hyperv+plugin&page=3
[5] https://issues.apache.org/jira/browse/CLOUDSTACK-999
[6] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Hyper-V+2012+%283.0%29+Support
[7] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Progress
[8] https://git-wip-us.apache.org/repos/asf/cloudstack/repo?p=cloudstack.git;a=blob;f=plugins/hypervisors/hyperv/DotNet/ServerResource/ServerResource.Tests/HypervResourceController1Test.cs;h=ec91e9ff21742bde78873ed7cee49f2423e425b9;hb=refs/heads/hyperv
[9] http://dlafferty.blogspot.co.uk/2013/08/building-your-microsoft-solution-with.html

Regards,
Devdeep

RE: [Merge] hyperv branch to master

Posted by Rajesh Battala <ra...@citrix.com>.
+1.

Thanks
Rajesh Battala

-----Original Message-----
From: Devdeep Singh 
Sent: Monday, October 28, 2013 5:11 PM
To: dev@cloudstack.apache.org
Cc: Donal Lafferty; Rajesh Battala; Anshul Gangwar
Subject: [Merge] hyperv branch to master

Hi,

I would like to merge the support for Hyperv to the master branch. Development for this has been done by Donal, Rajesh, Anshul and I on branch [1]. The feature was proposed for merge earlier [3] but unit tests for hyperv agent code were requested [4].

Checklist:
The development for the feature was earlier done in branch [2] but later moved to [1].
Jira ticket for the feature is here [5].
The FS can be found at [6] and [7].
Unit tests for the feature are available at [8]

This link [7] also provides details of third party libraries used by the plugin including their licenses. No source for these libraries is used, and the binaries are downloaded from their distributors at build time. No proprietary tools are required for the build.  For instance, C# compiled with Mono has been tested. Mono setup details can be found here [9].

[1] https://git-wip-us.apache.org/repos/asf/cloudstack/repo?p=cloudstack.git;a=shortlog;h=refs/heads/hyperv
[2] https://github.com/lafferty/cloudstack/tree/hyperv_plugin
[3] http://markmail.org/message/cm7kdwh6l2ea772e?q=list:org%2Eapache%2Eincubator%2Ecloudstack-%2A+Minimal+Hyperv+plugin
[4] http://markmail.org/message/vxknappvyovhmeyp?q=list:org%2Eapache%2Eincubator%2Ecloudstack-%2A+Minimal+Hyperv+plugin&page=3
[5] https://issues.apache.org/jira/browse/CLOUDSTACK-999
[6] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Hyper-V+2012+%283.0%29+Support
[7] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Progress
[8] https://git-wip-us.apache.org/repos/asf/cloudstack/repo?p=cloudstack.git;a=blob;f=plugins/hypervisors/hyperv/DotNet/ServerResource/ServerResource.Tests/HypervResourceController1Test.cs;h=ec91e9ff21742bde78873ed7cee49f2423e425b9;hb=refs/heads/hyperv
[9] http://dlafferty.blogspot.co.uk/2013/08/building-your-microsoft-solution-with.html

Regards,
Devdeep

RE: [Merge] hyperv branch to master

Posted by Devdeep Singh <de...@citrix.com>.
The changes have been merged to the master branch.

Regards,
Devdeep

-----Original Message-----
From: Devdeep Singh [mailto:devdeep.singh@citrix.com] 
Sent: Thursday, October 31, 2013 3:38 PM
To: dev@cloudstack.apache.org
Cc: Donal Lafferty; Rajesh Battala; Anshul Gangwar
Subject: RE: [Merge] hyperv branch to master

Thanks Darren. I'll start working on getting it merged into the master. I hope to finish it by Friday.

Regards,
Devdeep

-----Original Message-----
From: Darren Shepherd [mailto:darren.s.shepherd@gmail.com]
Sent: Tuesday, October 29, 2013 10:45 PM
To: dev@cloudstack.apache.org
Cc: Donal Lafferty; Rajesh Battala; Anshul Gangwar
Subject: Re: [Merge] hyperv branch to master

+1

When you merge you will get a conflict in the spring configuration.
componentContext.xml and others are gone now in master.  You will need to update to the new style.  The easiest will be to refer to XenServer spring config for an example of how to do it.  You can largely copy and paste the contents of plugins/hypervisors/xen/resources/META-INF/cloudstack and replace xenserver with hyperv.  You can also refer to https://cwiki.apache.org/confluence/display/CLOUDSTACK/Plug-ins%2C+Modules%2C+and+Extensions
for more in depth explaination of the changes.

Darren

On Tue, Oct 29, 2013 at 9:35 AM, David Nalley <da...@gnsa.us> wrote:
> On Mon, Oct 28, 2013 at 7:41 AM, Devdeep Singh <de...@citrix.com> wrote:
>> Hi,
>>
>> I would like to merge the support for Hyperv to the master branch. Development for this has been done by Donal, Rajesh, Anshul and I on branch [1]. The feature was proposed for merge earlier [3] but unit tests for hyperv agent code were requested [4].
>>
>
> I know this has been discussed several times, but what was the 
> decision about making the agent code live in its own repo?
> It's C#, might need to be signed to actually run easily on Windows, etc.
>
> --David

RE: [Merge] hyperv branch to master

Posted by Devdeep Singh <de...@citrix.com>.
Thanks Darren. I'll start working on getting it merged into the master. I hope to finish it by Friday.

Regards,
Devdeep

-----Original Message-----
From: Darren Shepherd [mailto:darren.s.shepherd@gmail.com] 
Sent: Tuesday, October 29, 2013 10:45 PM
To: dev@cloudstack.apache.org
Cc: Donal Lafferty; Rajesh Battala; Anshul Gangwar
Subject: Re: [Merge] hyperv branch to master

+1

When you merge you will get a conflict in the spring configuration.
componentContext.xml and others are gone now in master.  You will need to update to the new style.  The easiest will be to refer to XenServer spring config for an example of how to do it.  You can largely copy and paste the contents of plugins/hypervisors/xen/resources/META-INF/cloudstack and replace xenserver with hyperv.  You can also refer to https://cwiki.apache.org/confluence/display/CLOUDSTACK/Plug-ins%2C+Modules%2C+and+Extensions
for more in depth explaination of the changes.

Darren

On Tue, Oct 29, 2013 at 9:35 AM, David Nalley <da...@gnsa.us> wrote:
> On Mon, Oct 28, 2013 at 7:41 AM, Devdeep Singh <de...@citrix.com> wrote:
>> Hi,
>>
>> I would like to merge the support for Hyperv to the master branch. Development for this has been done by Donal, Rajesh, Anshul and I on branch [1]. The feature was proposed for merge earlier [3] but unit tests for hyperv agent code were requested [4].
>>
>
> I know this has been discussed several times, but what was the 
> decision about making the agent code live in its own repo?
> It's C#, might need to be signed to actually run easily on Windows, etc.
>
> --David

Re: [Merge] hyperv branch to master

Posted by Darren Shepherd <da...@gmail.com>.
+1

When you merge you will get a conflict in the spring configuration.
componentContext.xml and others are gone now in master.  You will need
to update to the new style.  The easiest will be to refer to XenServer
spring config for an example of how to do it.  You can largely copy
and paste the contents of
plugins/hypervisors/xen/resources/META-INF/cloudstack and replace
xenserver with hyperv.  You can also refer to
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Plug-ins%2C+Modules%2C+and+Extensions
for more in depth explaination of the changes.

Darren

On Tue, Oct 29, 2013 at 9:35 AM, David Nalley <da...@gnsa.us> wrote:
> On Mon, Oct 28, 2013 at 7:41 AM, Devdeep Singh <de...@citrix.com> wrote:
>> Hi,
>>
>> I would like to merge the support for Hyperv to the master branch. Development for this has been done by Donal, Rajesh, Anshul and I on branch [1]. The feature was proposed for merge earlier [3] but unit tests for hyperv agent code were requested [4].
>>
>
> I know this has been discussed several times, but what was the
> decision about making the agent code live in its own repo?
> It's C#, might need to be signed to actually run easily on Windows, etc.
>
> --David

Re: [Merge] hyperv branch to master

Posted by David Nalley <da...@gnsa.us>.
Indeed :)
And that answers my question - thanks!



On Tue, Oct 29, 2013 at 2:31 PM, Donal Lafferty
<do...@citrix.com> wrote:
> Hi David,
>
> I can assure you that if we knew of a reason to breakup our plugins into separate repos, it would have been brought up weeks ago.
>
> It is far, far easier to create a Master than to merge with Master :)
>
>
> DL
>
>
>> -----Original Message-----
>> From: David Nalley [mailto:david@gnsa.us]
>> Sent: 29 October 2013 17:37
>> To: dev@cloudstack.apache.org
>> Cc: Donal Lafferty; Rajesh Battala; Anshul Gangwar
>> Subject: Re: [Merge] hyperv branch to master
>>
>> Well - other projects within the ASF are finding a need to 'sign'
>> their convenience binaries, and folks are exploring those options now to find
>> something workable.
>>
>> Why put it off? Creating a repo takes 5 minutes. IF putting it in its own repo
>> and adjusting our release processes is the right thing to do, I'd rather do it
>> now than later. If it isn't the right thing to do, then staying put is fine as well.
>>
>> --David
>>
>> On Tue, Oct 29, 2013 at 1:29 PM, Chiradeep Vittal
>> <Ch...@citrix.com> wrote:
>> > That could be a decision to put off for later.
>> > The release process deals with single repos for now.
>> > The signing will come up during the build right? How do other OSS C#
>> > projects deal with it?
>> > Perhaps they release binaries in addition to source?
>> >
>> > On 10/29/13 9:35 AM, "David Nalley" <da...@gnsa.us> wrote:
>> >
>> >>On Mon, Oct 28, 2013 at 7:41 AM, Devdeep Singh
>> >><de...@citrix.com>
>> >>wrote:
>> >>> Hi,
>> >>>
>> >>> I would like to merge the support for Hyperv to the master branch.
>> >>>Development for this has been done by Donal, Rajesh, Anshul and I on
>> >>>branch [1]. The feature was proposed for merge earlier [3] but unit
>> >>>tests for hyperv agent code were requested [4].
>> >>>
>> >>
>> >>I know this has been discussed several times, but what was the
>> >>decision about making the agent code live in its own repo?
>> >>It's C#, might need to be signed to actually run easily on Windows, etc.
>> >>
>> >>--David
>> >

RE: [Merge] hyperv branch to master

Posted by Donal Lafferty <do...@citrix.com>.
Hi David,

I can assure you that if we knew of a reason to breakup our plugins into separate repos, it would have been brought up weeks ago.  

It is far, far easier to create a Master than to merge with Master :)


DL


> -----Original Message-----
> From: David Nalley [mailto:david@gnsa.us]
> Sent: 29 October 2013 17:37
> To: dev@cloudstack.apache.org
> Cc: Donal Lafferty; Rajesh Battala; Anshul Gangwar
> Subject: Re: [Merge] hyperv branch to master
> 
> Well - other projects within the ASF are finding a need to 'sign'
> their convenience binaries, and folks are exploring those options now to find
> something workable.
> 
> Why put it off? Creating a repo takes 5 minutes. IF putting it in its own repo
> and adjusting our release processes is the right thing to do, I'd rather do it
> now than later. If it isn't the right thing to do, then staying put is fine as well.
> 
> --David
> 
> On Tue, Oct 29, 2013 at 1:29 PM, Chiradeep Vittal
> <Ch...@citrix.com> wrote:
> > That could be a decision to put off for later.
> > The release process deals with single repos for now.
> > The signing will come up during the build right? How do other OSS C#
> > projects deal with it?
> > Perhaps they release binaries in addition to source?
> >
> > On 10/29/13 9:35 AM, "David Nalley" <da...@gnsa.us> wrote:
> >
> >>On Mon, Oct 28, 2013 at 7:41 AM, Devdeep Singh
> >><de...@citrix.com>
> >>wrote:
> >>> Hi,
> >>>
> >>> I would like to merge the support for Hyperv to the master branch.
> >>>Development for this has been done by Donal, Rajesh, Anshul and I on
> >>>branch [1]. The feature was proposed for merge earlier [3] but unit
> >>>tests for hyperv agent code were requested [4].
> >>>
> >>
> >>I know this has been discussed several times, but what was the
> >>decision about making the agent code live in its own repo?
> >>It's C#, might need to be signed to actually run easily on Windows, etc.
> >>
> >>--David
> >

Re: [Merge] hyperv branch to master

Posted by David Nalley <da...@gnsa.us>.
Well - other projects within the ASF are finding a need to 'sign'
their convenience binaries, and folks are exploring those options now
to find something workable.

Why put it off? Creating a repo takes 5 minutes. IF putting it in its
own repo and adjusting our release processes is the right thing to do,
I'd rather do it now than later. If it isn't the right thing to do,
then staying put is fine as well.

--David

On Tue, Oct 29, 2013 at 1:29 PM, Chiradeep Vittal
<Ch...@citrix.com> wrote:
> That could be a decision to put off for later.
> The release process deals with single repos for now.
> The signing will come up during the build right? How do other OSS C#
> projects deal with it?
> Perhaps they release binaries in addition to source?
>
> On 10/29/13 9:35 AM, "David Nalley" <da...@gnsa.us> wrote:
>
>>On Mon, Oct 28, 2013 at 7:41 AM, Devdeep Singh <de...@citrix.com>
>>wrote:
>>> Hi,
>>>
>>> I would like to merge the support for Hyperv to the master branch.
>>>Development for this has been done by Donal, Rajesh, Anshul and I on
>>>branch [1]. The feature was proposed for merge earlier [3] but unit
>>>tests for hyperv agent code were requested [4].
>>>
>>
>>I know this has been discussed several times, but what was the
>>decision about making the agent code live in its own repo?
>>It's C#, might need to be signed to actually run easily on Windows, etc.
>>
>>--David
>

Re: [Merge] hyperv branch to master

Posted by Chiradeep Vittal <Ch...@citrix.com>.
That could be a decision to put off for later.
The release process deals with single repos for now.
The signing will come up during the build right? How do other OSS C#
projects deal with it?
Perhaps they release binaries in addition to source?

On 10/29/13 9:35 AM, "David Nalley" <da...@gnsa.us> wrote:

>On Mon, Oct 28, 2013 at 7:41 AM, Devdeep Singh <de...@citrix.com>
>wrote:
>> Hi,
>>
>> I would like to merge the support for Hyperv to the master branch.
>>Development for this has been done by Donal, Rajesh, Anshul and I on
>>branch [1]. The feature was proposed for merge earlier [3] but unit
>>tests for hyperv agent code were requested [4].
>>
>
>I know this has been discussed several times, but what was the
>decision about making the agent code live in its own repo?
>It's C#, might need to be signed to actually run easily on Windows, etc.
>
>--David

Re: [Merge] hyperv branch to master

Posted by David Nalley <da...@gnsa.us>.
On Mon, Oct 28, 2013 at 7:41 AM, Devdeep Singh <de...@citrix.com> wrote:
> Hi,
>
> I would like to merge the support for Hyperv to the master branch. Development for this has been done by Donal, Rajesh, Anshul and I on branch [1]. The feature was proposed for merge earlier [3] but unit tests for hyperv agent code were requested [4].
>

I know this has been discussed several times, but what was the
decision about making the agent code live in its own repo?
It's C#, might need to be signed to actually run easily on Windows, etc.

--David

RE: [Merge] hyperv branch to master

Posted by Donal Lafferty <do...@citrix.com>.
+1

> -----Original Message-----
> From: Chiradeep Vittal
> Sent: 29 October 2013 06:43
> To: dev@cloudstack.apache.org
> Cc: Donal Lafferty; Rajesh Battala; Anshul Gangwar
> Subject: Re: [Merge] hyperv branch to master
> 
> +1
> 
> On 10/28/13 4:41 AM, "Devdeep Singh" <de...@citrix.com> wrote:
> 
> >Hi,
> >
> >I would like to merge the support for Hyperv to the master branch.
> >Development for this has been done by Donal, Rajesh, Anshul and I on
> >branch [1]. The feature was proposed for merge earlier [3] but unit
> >tests for hyperv agent code were requested [4].
> >
> >Checklist:
> >The development for the feature was earlier done in branch [2] but
> >later moved to [1].
> >Jira ticket for the feature is here [5].
> >The FS can be found at [6] and [7].
> >Unit tests for the feature are available at [8]
> >
> >This link [7] also provides details of third party libraries used by
> >the plugin including their licenses. No source for these libraries is
> >used, and the binaries are downloaded from their distributors at build
> >time. No proprietary tools are required for the build.  For instance,
> >C# compiled with Mono has been tested. Mono setup details can be found
> here [9].
> >
> >[1]
> >https://git-wip-us.apache.org/repos/asf/cloudstack/repo?p=cloudstack.gi
> >t;a
> >=shortlog;h=refs/heads/hyperv
> >[2] https://github.com/lafferty/cloudstack/tree/hyperv_plugin
> >[3]
> >http://markmail.org/message/cm7kdwh6l2ea772e?q=list:org%2Eapache%2
> Eincu
> >bat or%2Ecloudstack-%2A+Minimal+Hyperv+plugin
> >[4]
> >http://markmail.org/message/vxknappvyovhmeyp?q=list:org%2Eapache%
> 2Eincu
> >bat
> >or%2Ecloudstack-%2A+Minimal+Hyperv+plugin&page=3
> >[5] https://issues.apache.org/jira/browse/CLOUDSTACK-999
> >[6]
> >https://cwiki.apache.org/confluence/display/CLOUDSTACK/Hyper-
> V+2012+%28
> >3.0
> >%29+Support
> >[7] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Progress
> >[8]
> >https://git-wip-us.apache.org/repos/asf/cloudstack/repo?p=cloudstack.gi
> >t;a
> >=blob;f=plugins/hypervisors/hyperv/DotNet/ServerResource/ServerResou
> rce
> >.Te
> >sts/HypervResourceController1Test.cs;h=ec91e9ff21742bde78873ed7cee49
> f24
> >23e
> >425b9;hb=refs/heads/hyperv
> >[9]
> >http://dlafferty.blogspot.co.uk/2013/08/building-your-microsoft-solutio
> >n-w
> >ith.html
> >
> >Regards,
> >Devdeep
> >
> >

Re: [Merge] hyperv branch to master

Posted by Chiradeep Vittal <Ch...@citrix.com>.
+1

On 10/28/13 4:41 AM, "Devdeep Singh" <de...@citrix.com> wrote:

>Hi,
>
>I would like to merge the support for Hyperv to the master branch.
>Development for this has been done by Donal, Rajesh, Anshul and I on
>branch [1]. The feature was proposed for merge earlier [3] but unit tests
>for hyperv agent code were requested [4].
>
>Checklist:
>The development for the feature was earlier done in branch [2] but later
>moved to [1].
>Jira ticket for the feature is here [5].
>The FS can be found at [6] and [7].
>Unit tests for the feature are available at [8]
>
>This link [7] also provides details of third party libraries used by the
>plugin including their licenses. No source for these libraries is used,
>and the binaries are downloaded from their distributors at build time. No
>proprietary tools are required for the build.  For instance, C# compiled
>with Mono has been tested. Mono setup details can be found here [9].
>
>[1] 
>https://git-wip-us.apache.org/repos/asf/cloudstack/repo?p=cloudstack.git;a
>=shortlog;h=refs/heads/hyperv
>[2] https://github.com/lafferty/cloudstack/tree/hyperv_plugin
>[3] 
>http://markmail.org/message/cm7kdwh6l2ea772e?q=list:org%2Eapache%2Eincubat
>or%2Ecloudstack-%2A+Minimal+Hyperv+plugin
>[4] 
>http://markmail.org/message/vxknappvyovhmeyp?q=list:org%2Eapache%2Eincubat
>or%2Ecloudstack-%2A+Minimal+Hyperv+plugin&page=3
>[5] https://issues.apache.org/jira/browse/CLOUDSTACK-999
>[6] 
>https://cwiki.apache.org/confluence/display/CLOUDSTACK/Hyper-V+2012+%283.0
>%29+Support
>[7] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Progress
>[8] 
>https://git-wip-us.apache.org/repos/asf/cloudstack/repo?p=cloudstack.git;a
>=blob;f=plugins/hypervisors/hyperv/DotNet/ServerResource/ServerResource.Te
>sts/HypervResourceController1Test.cs;h=ec91e9ff21742bde78873ed7cee49f2423e
>425b9;hb=refs/heads/hyperv
>[9] 
>http://dlafferty.blogspot.co.uk/2013/08/building-your-microsoft-solution-w
>ith.html
>
>Regards,
>Devdeep
>
>