You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "m1a2st (via GitHub)" <gi...@apache.org> on 2024/08/18 02:37:26 UTC
[PR] MINOR: inter.broker.protocol.version is not clearly in KRaft and Zookeeper mode [kafka]
m1a2st opened a new pull request, #16910:
URL: https://github.com/apache/kafka/pull/16910
In Zookeeper mode, use `inter.broker.protocol.version' configuration to setting the MV, but it doesn't work in KRaft mode, thus I think the document should description more clearly on the config.
I also addressed this description for older version document in this [PR](https://github.com/apache/kafka-site/pull/625)
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: inter.broker.protocol.version is not clearly in KRaft and Zookeeper mode [kafka]
Posted by "m1a2st (via GitHub)" <gi...@apache.org>.
m1a2st commented on code in PR #16910:
URL: https://github.com/apache/kafka/pull/16910#discussion_r1721105945
##########
server/src/main/java/org/apache/kafka/server/config/ReplicationConfigs.java:
##########
@@ -122,7 +122,8 @@ public class ReplicationConfigs {
public static final String INTER_BROKER_PROTOCOL_VERSION_DEFAULT = MetadataVersion.latestProduction().version();
public static final String INTER_BROKER_PROTOCOL_VERSION_DOC = "Specify which version of the inter-broker protocol will be used.\n" +
". This is typically bumped after all brokers were upgraded to a new version.\n" +
- " Example of some valid values are: 0.8.0, 0.8.1, 0.8.1.1, 0.8.2, 0.8.2.0, 0.8.2.1, 0.9.0.0, 0.9.0.1 Check MetadataVersion for the full list.";
+ " Example of some valid values are: 0.8.0, 0.8.1, 0.8.1.1, 0.8.2, 0.8.2.0, 0.8.2.1, 0.9.0.0, 0.9.0.1 Check MetadataVersion for the full list.\n" +
+ "This configuration is only applicable in Zookeeper mode, Use `metadata.version` config for KRaft instead.";
Review Comment:
Hello @chia7712, When I read the [KIP-900](https://cwiki.apache.org/confluence/display/KAFKA/KIP-900%3A+KRaft+kafka-storage.sh+API+additions+to+support+SCRAM+for+Kafka+Brokers), It seens that we should use `kafka-storage [--release-version RELEASE_VERSION]`, but in [KIP-778](https://cwiki.apache.org/confluence/display/KAFKA/KIP-778%3A+KRaft+to+KRaft+Upgrades), if we want upgrade, should use `kafka-features --bootstrap-server [--metadata METADATA]` and `kafka-storage [--metadata-version VERSION] `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: inter.broker.protocol.version is not clearly in KRaft and Zookeeper mode [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #16910:
URL: https://github.com/apache/kafka/pull/16910#discussion_r1721040005
##########
server/src/main/java/org/apache/kafka/server/config/ReplicationConfigs.java:
##########
@@ -122,7 +122,8 @@ public class ReplicationConfigs {
public static final String INTER_BROKER_PROTOCOL_VERSION_DEFAULT = MetadataVersion.latestProduction().version();
public static final String INTER_BROKER_PROTOCOL_VERSION_DOC = "Specify which version of the inter-broker protocol will be used.\n" +
". This is typically bumped after all brokers were upgraded to a new version.\n" +
- " Example of some valid values are: 0.8.0, 0.8.1, 0.8.1.1, 0.8.2, 0.8.2.0, 0.8.2.1, 0.9.0.0, 0.9.0.1 Check MetadataVersion for the full list.";
+ " Example of some valid values are: 0.8.0, 0.8.1, 0.8.1.1, 0.8.2, 0.8.2.0, 0.8.2.1, 0.9.0.0, 0.9.0.1 Check MetadataVersion for the full list.\n" +
+ "This configuration is only applicable in Zookeeper mode, Use `metadata.version` config for KRaft instead.";
Review Comment:
pardon me, do we have "metadata.version" config? According to `kafka-storage.sh`, the related config name is `release-version`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: inter.broker.protocol.version is not clearly in KRaft and Zookeeper mode [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #16910:
URL: https://github.com/apache/kafka/pull/16910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org