You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "NSAmelchev (via GitHub)" <gi...@apache.org> on 2023/06/07 15:31:50 UTC

[GitHub] [ignite] NSAmelchev commented on a diff in pull request #10764: IGNITE-19652 Adapt to DirectByteBuffer ctor changes in JDK 21

NSAmelchev commented on code in PR #10764:
URL: https://github.com/apache/ignite/pull/10764#discussion_r1221802767


##########
modules/core/src/main/java/org/apache/ignite/internal/util/GridUnsafe.java:
##########
@@ -1660,6 +1661,12 @@ private static Method newDirectBufferMethod(Object nioAccessObj) {
         return javaVer < 9 ? "sun" : "jdk.internal";
     }
 
+    @NotNull private static boolean directByteBufferLongLongCtor() {

Review Comment:
   I suggest to declare a local var in static class initialization and pass it to methods:
   
   ```
   boolean isDirectBufLongCap = majorJavaVersion(jdkVersion()) >= 21;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org