You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mcgilman <gi...@git.apache.org> on 2018/06/05 16:48:48 UTC
[GitHub] nifi pull request #2763: NIFI-5237: Considering proxy headers follow OIDC lo...
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2763
NIFI-5237: Considering proxy headers follow OIDC login
NIFI-5237:
- Ensuring the proxy headers are considered when redirecting the user following a OIDC or Knox login exchange.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mcgilman/nifi NIFI-5237
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2763.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2763
----
commit bb8ab4f4b411e56eae98eb180026b83ada7ac35f
Author: Matt Gilman <ma...@...>
Date: 2018-06-05T16:47:36Z
NIFI-5237:
- Ensuring the proxy headers are considered when redirecting the user following a OIDC or Knox login exchange.
----
---
[GitHub] nifi issue #2763: NIFI-5237: Considering proxy headers following OIDC login
Posted by maciejbozemoj <gi...@git.apache.org>.
Github user maciejbozemoj commented on the issue:
https://github.com/apache/nifi/pull/2763
Hi @mcgilman , I have checked locally NiFi and Keycloak, when trying to get into https://localhost:8443/nifi/ I'm redirected to https://localhost:8443/nifi-api/access/oidc/nifi/ with status code 404.
---
[GitHub] nifi issue #2763: NIFI-5237: Considering proxy headers following OIDC login
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2763
@maciejbozemoj Yup. I've verified the existing code did not work and the proposed changes do work with my setup. That's why I was surprised with the behavior you reported originally. Thanks again for assisting with the review!
---
[GitHub] nifi issue #2763: NIFI-5237: Considering proxy headers following OIDC login
Posted by maciejbozemoj <gi...@git.apache.org>.
Github user maciejbozemoj commented on the issue:
https://github.com/apache/nifi/pull/2763
@mcgilman, I made docker-compose for set up and today I couldn't reproduce it, maybe it was my environment failure. I would like to know if you managed to test it locally with and without proxy.
---
[GitHub] nifi issue #2763: NIFI-5237: Considering proxy headers following OIDC login
Posted by bbende <gi...@git.apache.org>.
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2763
+1 looks good, will merge
---
[GitHub] nifi pull request #2763: NIFI-5237: Considering proxy headers following OIDC...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2763
---
[GitHub] nifi issue #2763: NIFI-5237: Considering proxy headers following OIDC login
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2763
@maciejbozemoj Thanks for assisting with the review! Can you please describe your environment and the behavior your seeing in more detail? Are you running behind a proxy? What proxy headers are you setting? Are you successfully directed to KeyCloak to login? What is the callback URL sent to KeyCloak?
---