[GitHub] [activemq-artemis] Havret commented on a change in pull request #3063: ARTEMIS-2692 refactor queue creation

[GitBox <gi...@apache.org>]

Havret commented on a change in pull request #3063: ARTEMIS-2692 refactor queue creation
URL: https://github.com/apache/activemq-artemis/pull/3063#discussion_r403730390
 
 

 ##########
 File path: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java
 ##########
 @@ -298,6 +299,28 @@ public void createAddress(final SimpleString address, RoutingType routingType, b
       createAddress(address, EnumSet.of(routingType), autoCreated);
    }
 
+   @Override
+   public void createQueue(QueueConfiguration queueConfiguration) throws ActiveMQException {
+      internalCreateQueue(queueConfiguration);
+   }
+
+   @Override
+   public void createSharedQueue(QueueConfiguration queueConfiguration) throws ActiveMQException {
+      checkClosed();
+
+      startCall();
+      try {
+         sessionContext.createSharedQueue(queueConfiguration);
+      } finally {
+         endCall();
+      }
+   }
+
+   @Override
+   public void createTemporaryQueue(QueueConfiguration queueConfiguration) throws ActiveMQException {
 
 Review comment:
   I'm wondering, do we still need all these overloads like `createSharedQueue` and `createTemporaryQueue`. Shouldn't the intent be expressed by the state of `QueueConfiguration` object itself? As the client of the api, I wouldn't expect that the configuration I am passing will be mutated. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services