[GitHub] [age] AdeelAhmedIqbal opened a new pull request, #955: Update cypher_parse_node.c

["AdeelAhmedIqbal (via GitHub)" <gi...@apache.org>]

AdeelAhmedIqbal opened a new pull request, #955:
URL: https://github.com/apache/age/pull/955

   1) Add header guards: Add header guards to prevent multiple inclusions of the same header file. This ensures that the code is included only once in a translation unit.
   
   2) Group header files: Group related header files together to improve readability and maintainability. This makes it easier to identify dependencies and understand the code's structure.
   
   3) Avoid unnecessary typecasting: In the make_cypher_parsestate function, there is no need to cast parent_cpstate to ParseState*. Instead, assign it directly to ParseState*:
   
   4) Use pg_strdup instead of palloc0 and snprintf: Instead of using palloc0 and snprintf to generate the default alias name in the get_next_default_alias function, you can use pg_strdup to allocate and copy the string in a more concise way
   
   5) Avoid unnecessary typecasting in the find_rte function: Since cypher_parsestate is defined as a struct containing a ParseState as its first member, there is no need to cast cpstate to ParseState* in the find_rte function. You can directly access the ParseState member from cpstate:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [age] jrgemignani closed pull request #955: Update cypher_parse_node.c

["jrgemignani (via GitHub)" <gi...@apache.org>]

jrgemignani closed pull request #955: Update cypher_parse_node.c
URL: https://github.com/apache/age/pull/955


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [age] jrgemignani commented on pull request #955: Update cypher_parse_node.c

["jrgemignani (via GitHub)" <gi...@apache.org>]

jrgemignani commented on PR #955:
URL: https://github.com/apache/age/pull/955#issuecomment-1570605003

   @AdeelAhmedIqbal
   
   1. You need to verify that your PR builds, without errors, locally before submitting it.
   2. Your commit log entry does not follow our guidelines of sticking to a maximum of 80 characters.
   3. Your header guards do not follow standards used by AGE or PG.
   4. You #include your own header - that is improperly named - in the incorrect location.
   5. You don't bother to include your header in the PR.
   6. Your changes make this file less readable and less maintainable.
   7. You do not follow our coding standards or structure for your changes or additions.
   8. You improperly use PG functions.
   
   Rejected.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org