You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mina.apache.org by tr...@apache.org on 2007/10/16 10:36:18 UTC
svn commit: r585077 - in /mina:
branches/1.0/core/src/main/java/org/apache/mina/transport/vmpipe/support/
branches/1.1/core/src/main/java/org/apache/mina/transport/vmpipe/support/
trunk/core/src/main/java/org/apache/mina/common/
Author: trustin
Date: Tue Oct 16 01:36:14 2007
New Revision: 585077
URL: http://svn.apache.org/viewvc?rev=585077&view=rev
Log:
Resolved issue: DIRMINA-452 (IdentittyHashMap Iterator has bug in it.)
* Replaced IdentityHashMap/Set with HashMap/Set in IdleStatusChecker.
* I couldn't find any other places that calls Iterator.remove() on IdentityHashMap/Set, so I retained the other code.
Modified:
mina/branches/1.0/core/src/main/java/org/apache/mina/transport/vmpipe/support/VmPipeIdleStatusChecker.java
mina/branches/1.1/core/src/main/java/org/apache/mina/transport/vmpipe/support/VmPipeIdleStatusChecker.java
mina/trunk/core/src/main/java/org/apache/mina/common/IdleStatusChecker.java
Modified: mina/branches/1.0/core/src/main/java/org/apache/mina/transport/vmpipe/support/VmPipeIdleStatusChecker.java
URL: http://svn.apache.org/viewvc/mina/branches/1.0/core/src/main/java/org/apache/mina/transport/vmpipe/support/VmPipeIdleStatusChecker.java?rev=585077&r1=585076&r2=585077&view=diff
==============================================================================
--- mina/branches/1.0/core/src/main/java/org/apache/mina/transport/vmpipe/support/VmPipeIdleStatusChecker.java (original)
+++ mina/branches/1.0/core/src/main/java/org/apache/mina/transport/vmpipe/support/VmPipeIdleStatusChecker.java Tue Oct 16 01:36:14 2007
@@ -19,7 +19,7 @@
*/
package org.apache.mina.transport.vmpipe.support;
-import java.util.IdentityHashMap;
+import java.util.HashMap;
import java.util.Iterator;
import java.util.Map;
@@ -38,7 +38,7 @@
return INSTANCE;
}
- private final Map sessions = new IdentityHashMap(); // will use as a set
+ private final Map sessions = new HashMap(); // will use as a set
private final Worker worker = new Worker();
Modified: mina/branches/1.1/core/src/main/java/org/apache/mina/transport/vmpipe/support/VmPipeIdleStatusChecker.java
URL: http://svn.apache.org/viewvc/mina/branches/1.1/core/src/main/java/org/apache/mina/transport/vmpipe/support/VmPipeIdleStatusChecker.java?rev=585077&r1=585076&r2=585077&view=diff
==============================================================================
--- mina/branches/1.1/core/src/main/java/org/apache/mina/transport/vmpipe/support/VmPipeIdleStatusChecker.java (original)
+++ mina/branches/1.1/core/src/main/java/org/apache/mina/transport/vmpipe/support/VmPipeIdleStatusChecker.java Tue Oct 16 01:36:14 2007
@@ -19,11 +19,11 @@
*/
package org.apache.mina.transport.vmpipe.support;
+import java.util.HashSet;
import java.util.Iterator;
import java.util.Set;
import org.apache.mina.common.IdleStatus;
-import org.apache.mina.util.IdentityHashSet;
/**
* Dectects idle sessions and fires <tt>sessionIdle</tt> events to them.
@@ -38,7 +38,7 @@
return INSTANCE;
}
- private final Set<VmPipeSessionImpl> sessions = new IdentityHashSet<VmPipeSessionImpl>();
+ private final Set<VmPipeSessionImpl> sessions = new HashSet<VmPipeSessionImpl>();
private final Worker worker = new Worker();
Modified: mina/trunk/core/src/main/java/org/apache/mina/common/IdleStatusChecker.java
URL: http://svn.apache.org/viewvc/mina/trunk/core/src/main/java/org/apache/mina/common/IdleStatusChecker.java?rev=585077&r1=585076&r2=585077&view=diff
==============================================================================
--- mina/trunk/core/src/main/java/org/apache/mina/common/IdleStatusChecker.java (original)
+++ mina/trunk/core/src/main/java/org/apache/mina/common/IdleStatusChecker.java Tue Oct 16 01:36:14 2007
@@ -19,11 +19,10 @@
*/
package org.apache.mina.common;
+import java.util.HashSet;
import java.util.Iterator;
import java.util.Set;
-import org.apache.mina.util.IdentityHashSet;
-
/**
* Dectects idle sessions and fires <tt>sessionIdle</tt> events to them.
*
@@ -37,7 +36,7 @@
return INSTANCE;
}
- private final Set<AbstractIoSession> sessions = new IdentityHashSet<AbstractIoSession>();
+ private final Set<AbstractIoSession> sessions = new HashSet<AbstractIoSession>();
private final Worker worker = new Worker();