You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by sgrebnov <gi...@git.apache.org> on 2014/10/27 15:58:12 UTC
[GitHub] cordova-android pull request: CB-7881 Android tooling shouldn't lo...
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-android/pull/130
CB-7881 Android tooling shouldn't lock application directory
https://issues.apache.org/jira/browse/CB-7881
Use temp directory when running adb command to make sure adb server is not started in working directory and does not lock it
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-android CB-7881
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/130.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #130
----
commit 2c7fb5cb619c07a445b23b49503f68ecbf772f84
Author: sgrebnov <v-...@microsoft.com>
Date: 2014-10-27T14:14:35Z
CB-7881 Android tooling shouldn't lock application directory
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: CB-7881 Android tooling shouldn't lo...
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-android/pull/130#issuecomment-61223212
Could someone review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: CB-7881 Android tooling shouldn't lo...
Posted by cmarcelk <gi...@git.apache.org>.
Github user cmarcelk commented on the pull request:
https://github.com/apache/cordova-android/pull/130#issuecomment-61550705
One of my concerns looking at the changes is that it would leave a new tmp directory laying around on the filesystem everytime one was needed, but looking at the docs for os.tmpdir() I see it just returns the system's default dir for tempfiles. Cool.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: CB-7881 Android tooling shouldn't lo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/130
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org