You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by smarthi <gi...@git.apache.org> on 2014/11/20 00:23:14 UTC

[GitHub] incubator-flink pull request: Code cleanups, replaced for loops wi...

GitHub user smarthi opened a pull request:

    https://github.com/apache/incubator-flink/pull/221

    Code cleanups, replaced for loops with an iterator, etc...

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/smarthi/incubator-flink suneel

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-flink/pull/221.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #221
    
----
commit 9b8e7e41f5d4bee7747ea2287bb8a78a4d8caf2d
Author: Suneel Marthi <su...@gmail.com>
Date:   2014-11-19T23:22:09Z

    Code cleanups, replaced for loops with an iterator, etc...

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-flink pull request: Code cleanups, replaced for loops wi...

Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:

    https://github.com/apache/incubator-flink/pull/221#issuecomment-63793945
  
    I agree with both of @StephanEwen's comments and will merge this now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-flink pull request: Code cleanups, replaced for loops wi...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/221#discussion_r20637988
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/iterative/io/SerializedUpdateBuffer.java ---
    @@ -259,7 +261,7 @@ public ReadEnd switchBuffers() throws IOException {
     
     		private final LinkedBlockingQueue<MemorySegment> emptyBufferTarget;
     
    -		private final ArrayDeque<MemorySegment> fullBufferSource;
    --- End diff --
    
    I sometimes strongly type the fields to the collection implementation (rather than the interface) in performance critical parts.
    
    That way, we can make strong assumptions on the complexity of certain operations (such as random access is constant in an ArrayList is constant, vs linear in a LinkedList).
    
    I think that this in not crucial here, but in general, not all such declared occurrences are accidental.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-flink pull request: Code cleanups, replaced for loops wi...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-flink/pull/221


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-flink pull request: Code cleanups, replaced for loops wi...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:

    https://github.com/apache/incubator-flink/pull/221#issuecomment-63790641
  
    I think this is good to merge!
    
    Thanks for the patch!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---