You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/03/31 06:57:03 UTC
[GitHub] [cloudstack] Pearl1594 opened a new pull request #6182: UI: Fix minor UI issues
Pearl1594 opened a new pull request #6182:
URL: https://github.com/apache/cloudstack/pull/6182
### Description
This PR address some minor UI issues:
1. Missing component - TooltipLabel in ScaleVM component
2. Issue observed when seaching for a non-existent offering in the scaleVM form:
3. Missing variable in ACListRulesTab
4. In the Capacity Dashboard view, on changing the zone, the zone name gets replaced by the zone index
Before:
After changing Zone:
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #6182: UI: Fix minor UI issues
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #6182:
URL: https://github.com/apache/cloudstack/pull/6182#discussion_r839403376
##########
File path: server/src/main/java/com/cloud/network/vpc/NetworkACLServiceImpl.java
##########
@@ -1146,6 +1146,9 @@ protected void validateMoveAclRulesData(NetworkACLItemVO ruleBeingMoved, Network
NetworkACLVO acl = _networkACLDao.findById(aclId);
Vpc vpc = _entityMgr.findById(Vpc.class, acl.getVpcId());
Account caller = CallContext.current().getCallingAccount();
+ if (acl.getVpcId() == null) {
+ throw new InvalidParameterValueException("Unable to move rules for a default ACL");
+ }
Review comment:
good .. no problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6182: UI: Fix minor UI issues
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6182:
URL: https://github.com/apache/cloudstack/pull/6182#issuecomment-1084302857
@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6182: UI: Fix minor UI issues
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6182:
URL: https://github.com/apache/cloudstack/pull/6182#issuecomment-1084387668
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6182 (SL-JID-1323)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6182: UI: Fix minor UI issues
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6182:
URL: https://github.com/apache/cloudstack/pull/6182#issuecomment-1084316660
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6182 (SL-JID-1322)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #6182: UI: Fix minor UI issues
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #6182:
URL: https://github.com/apache/cloudstack/pull/6182#issuecomment-1084302486
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #6182: UI: Fix minor UI issues
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #6182:
URL: https://github.com/apache/cloudstack/pull/6182#issuecomment-1084380861
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6182: UI: Fix minor UI issues
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6182:
URL: https://github.com/apache/cloudstack/pull/6182#issuecomment-1086112679
@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6182: UI: Fix minor UI issues
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6182:
URL: https://github.com/apache/cloudstack/pull/6182#issuecomment-1085455020
@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #6182: UI: Fix minor UI issues
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #6182:
URL: https://github.com/apache/cloudstack/pull/6182#issuecomment-1085454626
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #6182: UI: Fix minor UI issues
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #6182:
URL: https://github.com/apache/cloudstack/pull/6182#issuecomment-1085449910
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6182: UI: Fix minor UI issues
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6182:
URL: https://github.com/apache/cloudstack/pull/6182#issuecomment-1084382946
@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6182: UI: Fix minor UI issues
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6182:
URL: https://github.com/apache/cloudstack/pull/6182#issuecomment-1086117820
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6182 (SL-JID-1328)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on a change in pull request #6182: UI: Fix minor UI issues
Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #6182:
URL: https://github.com/apache/cloudstack/pull/6182#discussion_r840262096
##########
File path: ui/src/views/infra/MigrateData.vue
##########
@@ -115,14 +117,23 @@ export default {
})
},
fetchImageStores () {
- this.loading = true
- api('listImageStores').then(json => {
- this.imageStores = json.listimagestoresresponse.imagestore || []
- this.form.srcpool = this.imageStores[0].id || ''
- }).finally(() => {
- this.loading = false
+ return new Promise((resolve, reject) => {
+ this.loading = true
+ api('listImageStores').then(json => {
+ this.imageStores = json.listimagestoresresponse.imagestore || []
+ console.log(this.imageStores)
Review comment:
@Pearl1594 Please remove this log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] jbampton commented on a change in pull request #6182: UI: Fix minor UI issues
Posted by GitBox <gi...@apache.org>.
jbampton commented on a change in pull request #6182:
URL: https://github.com/apache/cloudstack/pull/6182#discussion_r840268057
##########
File path: ui/src/views/network/AclListRulesTab.vue
##########
@@ -1,3 +1,4 @@
+
Review comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #6182: UI: Fix minor UI issues
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #6182:
URL: https://github.com/apache/cloudstack/pull/6182#discussion_r839395668
##########
File path: server/src/main/java/com/cloud/network/vpc/NetworkACLServiceImpl.java
##########
@@ -1146,6 +1146,9 @@ protected void validateMoveAclRulesData(NetworkACLItemVO ruleBeingMoved, Network
NetworkACLVO acl = _networkACLDao.findById(aclId);
Vpc vpc = _entityMgr.findById(Vpc.class, acl.getVpcId());
Account caller = CallContext.current().getCallingAccount();
+ if (acl.getVpcId() == null) {
+ throw new InvalidParameterValueException("Unable to move rules for a default ACL");
+ }
Review comment:
Ah sorry - this wasn't to be part of this PR - this is ideally to prevent an NPE that happens when we try re-ordering rules for a default acl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6182: UI: Fix minor UI issues
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6182:
URL: https://github.com/apache/cloudstack/pull/6182#issuecomment-1086111647
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #6182: UI: Fix minor UI issues
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #6182:
URL: https://github.com/apache/cloudstack/pull/6182#discussion_r839386519
##########
File path: server/src/main/java/com/cloud/network/vpc/NetworkACLServiceImpl.java
##########
@@ -1146,6 +1146,9 @@ protected void validateMoveAclRulesData(NetworkACLItemVO ruleBeingMoved, Network
NetworkACLVO acl = _networkACLDao.findById(aclId);
Vpc vpc = _entityMgr.findById(Vpc.class, acl.getVpcId());
Account caller = CallContext.current().getCallingAccount();
+ if (acl.getVpcId() == null) {
+ throw new InvalidParameterValueException("Unable to move rules for a default ACL");
+ }
Review comment:
@Pearl1594
What does this change fix ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6182: UI: Fix minor UI issues
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6182:
URL: https://github.com/apache/cloudstack/pull/6182#issuecomment-1085457895
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6182 (SL-JID-1326)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org