Re: [PR] resolve template fields init checks for `bigquery` [airflow]

["Taragolis (via GitHub)" <gi...@apache.org>]

Taragolis commented on code in PR #37586:
URL: https://github.com/apache/airflow/pull/37586#discussion_r1497621224


##########
airflow/providers/google/cloud/operators/bigquery.py:
##########
@@ -2752,7 +2759,7 @@ def __init__(
         self.cancel_on_kill = cancel_on_kill
         self.result_retry = result_retry
         self.result_timeout = result_timeout
-        self.hook: BigQueryHook | None = None
+        self.hook = hook

Review Comment:
   ```suggestion
           self.hook: BigQueryHook | None = None
   ```



##########
airflow/providers/google/cloud/operators/bigquery.py:
##########
@@ -2738,6 +2744,7 @@ def __init__(
         result_timeout: float | None = None,
         deferrable: bool = conf.getboolean("operators", "default_deferrable", fallback=False),
         poll_interval: float = 4.0,
+        hook: BigQueryHook | None = None,

Review Comment:
   Hook into initialiser for the different purpose. It setting into the execute method.
   Better to use @cached_propery for this case. But anyway this change non relevant to the purpose of the PR 
   
   ```suggestion
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org