[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya commented on a diff in pull request #17: Pekko migration

["Seetaramayya (via GitHub)" <gi...@apache.org>]

Seetaramayya commented on code in PR #17:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/17#discussion_r1096646159


##########
build.sbt:
##########
@@ -274,11 +278,12 @@ lazy val docs = project
       "scaladoc.akka.kafka.base_url" -> s"/${(Preprocess / siteSubdirName).value}/",
       "javadoc.akka.kafka.base_url" -> "",
       // Akka
-      "akka.version" -> akkaVersion,
+      "pekko.version" -> pekkoVersion,
+      "scaladoc.base_url" -> "https://pekko.apache.org/docs/pekko-connectors-kafka/current/",

Review Comment:
   Package name was wrong thats why it was defaulting to `scaladoc.base_url` now it is adjusted. 
   Yes it was copy paste error, now pointing to `/api/` instead of `docs`. 
   
   Thanks for catching it, it is difficult to catch in the PR process



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org