You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/10/13 23:46:20 UTC

[GitHub] [airflow] uranusjr commented on a change in pull request #18964: Add pre-commit hook for common misspelling check in files

uranusjr commented on a change in pull request #18964:
URL: https://github.com/apache/airflow/pull/18964#discussion_r728524249



##########
File path: docs/spelling_wordlist.txt
##########
@@ -527,6 +529,7 @@ changelog
 charset
 checklicence
 checksums
+childs

Review comment:
       This is a misspell IMO

##########
File path: docs/apache-airflow/pipeline_example.csv
##########
@@ -87,7 +87,7 @@ Serial Number,Company Name,Employee Markme,Description,Leave
 9.78818E+12,TULSIDAS ' RAMAYAMark,Mark,ACK,0
 9.78818E+12,TALES OF HANUMAN,-,ACK,0
 9.78818E+12,VALMIKI'S RAMAYAMark,A C K,ACK,1
-9.78818E+12,THE BEST OF INIDAN WIT AND WISDOM,Mark,ACK,0
+9.78818E+12,THE BEST OF INIDAN WITH AND WISDOM,Mark,ACK,0

Review comment:
       Another one

##########
File path: airflow/providers/microsoft/azure/operators/wasb_delete_blob.py
##########
@@ -65,7 +65,7 @@ def __init__(
         self.ignore_if_missing = ignore_if_missing
 
     def execute(self, context: dict) -> None:
-        self.log.info('Deleting blob: %s\nin wasb://%s', self.blob_name, self.container_name)
+        self.log.info('Deleting blob: %s\n in wasb://%s', self.blob_name, self.container_name)

Review comment:
       This is a (pretty bad) false positive, I'm not confident with this if it can't handle escape sequences.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org