You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Keta Patel <pa...@us.ibm.com> on 2016/04/19 18:33:42 UTC
Review Request 46394: Can not save roles assigned to users and groups
on Manage Ambari -> Roles -> Block view
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46394/
-----------------------------------------------------------
Review request for Ambari, Andrii Tkach and Di Li.
Bugs: AMBARI-15958
https://issues.apache.org/jira/browse/AMBARI-15958
Repository: ambari
Description
-------
ISSUE:
Steps to reproduce:
1. Go to Manage Ambari -> Roles (Block View)
2. assign some role to some users or groups by typing their name in the respective Roles' box. (img1.tiff, img2.tiff)
3. Click on the Save button (Tick mark button) (img2.tiff)
4. We can see the names of the users/groups in the Roles' box. (img3.tiff)
5. Refresh the page, the names are no longer present in those boxes. (img4.tiff)
The Save button must save the roles for the users/groups present in the Roles' box.
CAUSE:
The controller handling the Block view is not able to call the "$scope.save()" function whenever any Roles' box is edited. This is because of an error in the name of the variable "isDataLoaded" used in condition of the if-clause.
(The associated JIRA is AMBARI-15802)
FIX:
Fix involves correcting the name of the variable "isDataLoaded".
Diffs
-----
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/ClustersManageAccessCtrl.js 4cb3328
Diff: https://reviews.apache.org/r/46394/diff/
Testing
-------
No tests are included in the patch, because this requires manual verification by refreshing the page.
Thanks,
Keta Patel
Re: Review Request 46394: Can not save roles assigned to users and
groups on Manage Ambari -> Roles -> Block view
Posted by Keta Patel <pa...@us.ibm.com>.
> On April 19, 2016, 4:41 p.m., Di Li wrote:
> > Ship It!
Thank you Di!
- Keta
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46394/#review129558
-----------------------------------------------------------
On April 19, 2016, 4:33 p.m., Keta Patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46394/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 4:33 p.m.)
>
>
> Review request for Ambari, Andrii Tkach and Di Li.
>
>
> Bugs: AMBARI-15958
> https://issues.apache.org/jira/browse/AMBARI-15958
>
>
> Repository: ambari
>
>
> Description
> -------
>
> ISSUE:
> Steps to reproduce:
> 1. Go to Manage Ambari -> Roles (Block View)
> 2. assign some role to some users or groups by typing their name in the respective Roles' box. (img1.tiff, img2.tiff)
> 3. Click on the Save button (Tick mark button) (img2.tiff)
> 4. We can see the names of the users/groups in the Roles' box. (img3.tiff)
> 5. Refresh the page, the names are no longer present in those boxes. (img4.tiff)
>
> The Save button must save the roles for the users/groups present in the Roles' box.
>
> CAUSE:
> The controller handling the Block view is not able to call the "$scope.save()" function whenever any Roles' box is edited. This is because of an error in the name of the variable "isDataLoaded" used in condition of the if-clause.
> (The associated JIRA is AMBARI-15802)
>
> FIX:
> Fix involves correcting the name of the variable "isDataLoaded".
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/ClustersManageAccessCtrl.js 4cb3328
>
> Diff: https://reviews.apache.org/r/46394/diff/
>
>
> Testing
> -------
>
> No tests are included in the patch, because this requires manual verification by refreshing the page.
>
>
> Thanks,
>
> Keta Patel
>
>
Re: Review Request 46394: Can not save roles assigned to users and
groups on Manage Ambari -> Roles -> Block view
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46394/#review129558
-----------------------------------------------------------
Ship it!
Ship It!
- Di Li
On April 19, 2016, 4:33 p.m., Keta Patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46394/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 4:33 p.m.)
>
>
> Review request for Ambari, Andrii Tkach and Di Li.
>
>
> Bugs: AMBARI-15958
> https://issues.apache.org/jira/browse/AMBARI-15958
>
>
> Repository: ambari
>
>
> Description
> -------
>
> ISSUE:
> Steps to reproduce:
> 1. Go to Manage Ambari -> Roles (Block View)
> 2. assign some role to some users or groups by typing their name in the respective Roles' box. (img1.tiff, img2.tiff)
> 3. Click on the Save button (Tick mark button) (img2.tiff)
> 4. We can see the names of the users/groups in the Roles' box. (img3.tiff)
> 5. Refresh the page, the names are no longer present in those boxes. (img4.tiff)
>
> The Save button must save the roles for the users/groups present in the Roles' box.
>
> CAUSE:
> The controller handling the Block view is not able to call the "$scope.save()" function whenever any Roles' box is edited. This is because of an error in the name of the variable "isDataLoaded" used in condition of the if-clause.
> (The associated JIRA is AMBARI-15802)
>
> FIX:
> Fix involves correcting the name of the variable "isDataLoaded".
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/ClustersManageAccessCtrl.js 4cb3328
>
> Diff: https://reviews.apache.org/r/46394/diff/
>
>
> Testing
> -------
>
> No tests are included in the patch, because this requires manual verification by refreshing the page.
>
>
> Thanks,
>
> Keta Patel
>
>
Re: Review Request 46394: Can not save roles assigned to users and
groups on Manage Ambari -> Roles -> Block view
Posted by Keta Patel <pa...@us.ibm.com>.
> On April 20, 2016, 9:14 a.m., Andrii Tkach wrote:
> > Ship It!
>
> Keta Patel wrote:
> Thank you Andrii!
> Could you please help me push in the change
Thank you Andrii!
Committed to trunk:
https://github.com/apache/ambari/commit/e7f84d7181858a9f7acfbac79dbe1ee026504cac
- Keta
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46394/#review129711
-----------------------------------------------------------
On April 19, 2016, 4:33 p.m., Keta Patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46394/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 4:33 p.m.)
>
>
> Review request for Ambari, Andrii Tkach and Di Li.
>
>
> Bugs: AMBARI-15958
> https://issues.apache.org/jira/browse/AMBARI-15958
>
>
> Repository: ambari
>
>
> Description
> -------
>
> ISSUE:
> Steps to reproduce:
> 1. Go to Manage Ambari -> Roles (Block View)
> 2. assign some role to some users or groups by typing their name in the respective Roles' box. (img1.tiff, img2.tiff)
> 3. Click on the Save button (Tick mark button) (img2.tiff)
> 4. We can see the names of the users/groups in the Roles' box. (img3.tiff)
> 5. Refresh the page, the names are no longer present in those boxes. (img4.tiff)
>
> The Save button must save the roles for the users/groups present in the Roles' box.
>
> CAUSE:
> The controller handling the Block view is not able to call the "$scope.save()" function whenever any Roles' box is edited. This is because of an error in the name of the variable "isDataLoaded" used in condition of the if-clause.
> (The associated JIRA is AMBARI-15802)
>
> FIX:
> Fix involves correcting the name of the variable "isDataLoaded".
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/ClustersManageAccessCtrl.js 4cb3328
>
> Diff: https://reviews.apache.org/r/46394/diff/
>
>
> Testing
> -------
>
> No tests are included in the patch, because this requires manual verification by refreshing the page.
>
>
> Thanks,
>
> Keta Patel
>
>
Re: Review Request 46394: Can not save roles assigned to users and
groups on Manage Ambari -> Roles -> Block view
Posted by Keta Patel <pa...@us.ibm.com>.
> On April 20, 2016, 9:14 a.m., Andrii Tkach wrote:
> > Ship It!
Thank you Andrii!
Could you please help me push in the change
- Keta
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46394/#review129711
-----------------------------------------------------------
On April 19, 2016, 4:33 p.m., Keta Patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46394/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 4:33 p.m.)
>
>
> Review request for Ambari, Andrii Tkach and Di Li.
>
>
> Bugs: AMBARI-15958
> https://issues.apache.org/jira/browse/AMBARI-15958
>
>
> Repository: ambari
>
>
> Description
> -------
>
> ISSUE:
> Steps to reproduce:
> 1. Go to Manage Ambari -> Roles (Block View)
> 2. assign some role to some users or groups by typing their name in the respective Roles' box. (img1.tiff, img2.tiff)
> 3. Click on the Save button (Tick mark button) (img2.tiff)
> 4. We can see the names of the users/groups in the Roles' box. (img3.tiff)
> 5. Refresh the page, the names are no longer present in those boxes. (img4.tiff)
>
> The Save button must save the roles for the users/groups present in the Roles' box.
>
> CAUSE:
> The controller handling the Block view is not able to call the "$scope.save()" function whenever any Roles' box is edited. This is because of an error in the name of the variable "isDataLoaded" used in condition of the if-clause.
> (The associated JIRA is AMBARI-15802)
>
> FIX:
> Fix involves correcting the name of the variable "isDataLoaded".
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/ClustersManageAccessCtrl.js 4cb3328
>
> Diff: https://reviews.apache.org/r/46394/diff/
>
>
> Testing
> -------
>
> No tests are included in the patch, because this requires manual verification by refreshing the page.
>
>
> Thanks,
>
> Keta Patel
>
>
Re: Review Request 46394: Can not save roles assigned to users and
groups on Manage Ambari -> Roles -> Block view
Posted by Andrii Tkach <at...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46394/#review129711
-----------------------------------------------------------
Ship it!
Ship It!
- Andrii Tkach
On April 19, 2016, 4:33 p.m., Keta Patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46394/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 4:33 p.m.)
>
>
> Review request for Ambari, Andrii Tkach and Di Li.
>
>
> Bugs: AMBARI-15958
> https://issues.apache.org/jira/browse/AMBARI-15958
>
>
> Repository: ambari
>
>
> Description
> -------
>
> ISSUE:
> Steps to reproduce:
> 1. Go to Manage Ambari -> Roles (Block View)
> 2. assign some role to some users or groups by typing their name in the respective Roles' box. (img1.tiff, img2.tiff)
> 3. Click on the Save button (Tick mark button) (img2.tiff)
> 4. We can see the names of the users/groups in the Roles' box. (img3.tiff)
> 5. Refresh the page, the names are no longer present in those boxes. (img4.tiff)
>
> The Save button must save the roles for the users/groups present in the Roles' box.
>
> CAUSE:
> The controller handling the Block view is not able to call the "$scope.save()" function whenever any Roles' box is edited. This is because of an error in the name of the variable "isDataLoaded" used in condition of the if-clause.
> (The associated JIRA is AMBARI-15802)
>
> FIX:
> Fix involves correcting the name of the variable "isDataLoaded".
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/ClustersManageAccessCtrl.js 4cb3328
>
> Diff: https://reviews.apache.org/r/46394/diff/
>
>
> Testing
> -------
>
> No tests are included in the patch, because this requires manual verification by refreshing the page.
>
>
> Thanks,
>
> Keta Patel
>
>