You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by hb...@apache.org on 2011/07/04 00:29:38 UTC

svn commit: r1142512 - in /maven/plugins/trunk/maven-plugins: pom.xml src/site-docs/apt/index.apt

Author: hboutemy
Date: Sun Jul  3 22:29:37 2011
New Revision: 1142512

URL: http://svn.apache.org/viewvc?rev=1142512&view=rev
Log:
[MPOM-21] added run-its profile with common maven-invoker-plugin setup

Modified:
    maven/plugins/trunk/maven-plugins/pom.xml
    maven/plugins/trunk/maven-plugins/src/site-docs/apt/index.apt

Modified: maven/plugins/trunk/maven-plugins/pom.xml
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-plugins/pom.xml?rev=1142512&r1=1142511&r2=1142512&view=diff
==============================================================================
--- maven/plugins/trunk/maven-plugins/pom.xml (original)
+++ maven/plugins/trunk/maven-plugins/pom.xml Sun Jul  3 22:29:37 2011
@@ -252,6 +252,38 @@ under the License.
       </build>
     </profile>
     <profile>
+      <id>run-its</id>
+      <build>
+        <plugins>
+          <plugin>
+            <groupId>org.apache.maven.plugins</groupId>
+            <artifactId>maven-invoker-plugin</artifactId>
+            <configuration>
+              <debug>true</debug>
+              <projectsDirectory>src/it</projectsDirectory>
+              <cloneProjectsTo>${project.build.directory}/it</cloneProjectsTo>
+              <preBuildHookScript>setup</preBuildHookScript>
+              <postBuildHookScript>verify</postBuildHookScript>
+              <localRepositoryPath>${project.build.directory}/local-repo</localRepositoryPath>
+              <settingsFile>src/it/settings.xml</settingsFile>
+              <pomIncludes>
+                <pomInclude>*/pom.xml</pomInclude>
+              </pomIncludes>
+            </configuration>
+            <executions>
+              <execution>
+                <id>integration-test</id>
+                <goals>
+                  <goal>install</goal>
+                  <goal>run</goal>
+                </goals>
+              </execution>
+            </executions>
+          </plugin>
+        </plugins>
+      </build>
+    </profile>
+    <profile>
       <id>maven-3</id>
       <activation>
         <file>

Modified: maven/plugins/trunk/maven-plugins/src/site-docs/apt/index.apt
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-plugins/src/site-docs/apt/index.apt?rev=1142512&r1=1142511&r2=1142512&view=diff
==============================================================================
--- maven/plugins/trunk/maven-plugins/src/site-docs/apt/index.apt (original)
+++ maven/plugins/trunk/maven-plugins/src/site-docs/apt/index.apt Sun Jul  3 22:29:37 2011
@@ -31,9 +31,11 @@ Maven Plugins Parent POM
     This POM is the common parent of all of the Maven plugins
     in the Apache Maven project.
 
-    Every Maven plugin provide ITs (Integration Tests) to check real plugin execution.
-    Nothing is defined in this parent POM about ITs since every project has its own requirements
-    to run its ITs, but by convention, these ITs are defined by every plugin in a <<<run-its>>> profile:
+The <<<run-its>>> Profile
+
+    This POM provides <<<run-its>>> profile for running Integration Tests to check real plugin execution.
+    A default configuration for <<<maven-invoker-plugin>>> is defined, that every plugin needs to enhance
+    to match its prerequisite. Then ITs are launched in every plugin with following command:
 
 +---
 mvn -Prun-its verify



Re: svn commit: r1142512 - in /maven/plugins/trunk/maven-plugins: pom.xml src/site-docs/apt/index.apt

Posted by Hervé BOUTEMY <he...@free.fr>.
done
thanks for your review

Regards,

Hervé

Le lundi 4 juillet 2011, Stephen Connolly a écrit :
> On 3 July 2011 23:29,  <hb...@apache.org> wrote:
> > Author: hboutemy
> > Date: Sun Jul  3 22:29:37 2011
> > New Revision: 1142512
> > 
> > URL: http://svn.apache.org/viewvc?rev=1142512&view=rev
> > Log:
> > [MPOM-21] added run-its profile with common maven-invoker-plugin setup
> > 
> > Modified:
> >    maven/plugins/trunk/maven-plugins/pom.xml
> >    maven/plugins/trunk/maven-plugins/src/site-docs/apt/index.apt
> > 
> > Modified: maven/plugins/trunk/maven-plugins/pom.xml
> > URL:
> > http://svn.apache.org/viewvc/maven/plugins/trunk/maven-plugins/pom.xml?r
> > ev=1142512&r1=1142511&r2=1142512&view=diff
> > ========================================================================
> > ====== --- maven/plugins/trunk/maven-plugins/pom.xml (original)
> > +++ maven/plugins/trunk/maven-plugins/pom.xml Sun Jul  3 22:29:37 2011
> > @@ -252,6 +252,38 @@ under the License.
> >       </build>
> >     </profile>
> >     <profile>
> > +      <id>run-its</id>
> > +      <build>
> > +        <plugins>
> > +          <plugin>
> > +            <groupId>org.apache.maven.plugins</groupId>
> > +            <artifactId>maven-invoker-plugin</artifactId>
> > +            <configuration>
> > +              <debug>true</debug>
> > +              <projectsDirectory>src/it</projectsDirectory>
> > +            
> >  <cloneProjectsTo>${project.build.directory}/it</cloneProjectsTo> +    
> >          <preBuildHookScript>setup</preBuildHookScript>
> > +              <postBuildHookScript>verify</postBuildHookScript>
> > +            
> >  <localRepositoryPath>${project.build.directory}/local-repo</localReposi
> > toryPath> +              <settingsFile>src/it/settings.xml</settingsFile>
> > +              <pomIncludes>
> > +                <pomInclude>*/pom.xml</pomInclude>
> > +              </pomIncludes>
> > +            </configuration>
> > +            <executions>
> > +              <execution>
> > +                <id>integration-test</id>
> > +                <goals>
> > +                  <goal>install</goal>
> > +                  <goal>run</goal>
> 
> should be
> 
>   <goal>integration-test</goal>
>   <goal>verify</goal>
> 
> or else a failing integration test will stop the lifecycle before it
> gets to post-integration test. the run goal is best for when just
> testing from the cli or when you want to stop the lifecycle on
> failure. in general for a parent pom we should be using the split
> pair.
> 
> > +                </goals>
> > +              </execution>
> > +            </executions>
> > +          </plugin>
> > +        </plugins>
> > +      </build>
> > +    </profile>
> > +    <profile>
> >       <id>maven-3</id>
> >       <activation>
> >         <file>
> > 
> > Modified: maven/plugins/trunk/maven-plugins/src/site-docs/apt/index.apt
> > URL:
> > http://svn.apache.org/viewvc/maven/plugins/trunk/maven-plugins/src/site-
> > docs/apt/index.apt?rev=1142512&r1=1142511&r2=1142512&view=diff
> > ========================================================================
> > ====== --- maven/plugins/trunk/maven-plugins/src/site-docs/apt/index.apt
> > (original) +++
> > maven/plugins/trunk/maven-plugins/src/site-docs/apt/index.apt Sun Jul  3
> > 22:29:37 2011 @@ -31,9 +31,11 @@ Maven Plugins Parent POM
> >     This POM is the common parent of all of the Maven plugins
> >     in the Apache Maven project.
> > 
> > -    Every Maven plugin provide ITs (Integration Tests) to check real
> > plugin execution. -    Nothing is defined in this parent POM about ITs
> > since every project has its own requirements -    to run its ITs, but by
> > convention, these ITs are defined by every plugin in a <<<run-its>>>
> > profile: +The <<<run-its>>> Profile
> > +
> > +    This POM provides <<<run-its>>> profile for running Integration
> > Tests to check real plugin execution. +    A default configuration for
> > <<<maven-invoker-plugin>>> is defined, that every plugin needs to
> > enhance +    to match its prerequisite. Then ITs are launched in every
> > plugin with following command:
> > 
> >  +---
> >  mvn -Prun-its verify
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r1142512 - in /maven/plugins/trunk/maven-plugins: pom.xml src/site-docs/apt/index.apt

Posted by Stephen Connolly <st...@gmail.com>.
On 3 July 2011 23:29,  <hb...@apache.org> wrote:
> Author: hboutemy
> Date: Sun Jul  3 22:29:37 2011
> New Revision: 1142512
>
> URL: http://svn.apache.org/viewvc?rev=1142512&view=rev
> Log:
> [MPOM-21] added run-its profile with common maven-invoker-plugin setup
>
> Modified:
>    maven/plugins/trunk/maven-plugins/pom.xml
>    maven/plugins/trunk/maven-plugins/src/site-docs/apt/index.apt
>
> Modified: maven/plugins/trunk/maven-plugins/pom.xml
> URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-plugins/pom.xml?rev=1142512&r1=1142511&r2=1142512&view=diff
> ==============================================================================
> --- maven/plugins/trunk/maven-plugins/pom.xml (original)
> +++ maven/plugins/trunk/maven-plugins/pom.xml Sun Jul  3 22:29:37 2011
> @@ -252,6 +252,38 @@ under the License.
>       </build>
>     </profile>
>     <profile>
> +      <id>run-its</id>
> +      <build>
> +        <plugins>
> +          <plugin>
> +            <groupId>org.apache.maven.plugins</groupId>
> +            <artifactId>maven-invoker-plugin</artifactId>
> +            <configuration>
> +              <debug>true</debug>
> +              <projectsDirectory>src/it</projectsDirectory>
> +              <cloneProjectsTo>${project.build.directory}/it</cloneProjectsTo>
> +              <preBuildHookScript>setup</preBuildHookScript>
> +              <postBuildHookScript>verify</postBuildHookScript>
> +              <localRepositoryPath>${project.build.directory}/local-repo</localRepositoryPath>
> +              <settingsFile>src/it/settings.xml</settingsFile>
> +              <pomIncludes>
> +                <pomInclude>*/pom.xml</pomInclude>
> +              </pomIncludes>
> +            </configuration>
> +            <executions>
> +              <execution>
> +                <id>integration-test</id>
> +                <goals>
> +                  <goal>install</goal>
> +                  <goal>run</goal>

should be

  <goal>integration-test</goal>
  <goal>verify</goal>

or else a failing integration test will stop the lifecycle before it
gets to post-integration test. the run goal is best for when just
testing from the cli or when you want to stop the lifecycle on
failure. in general for a parent pom we should be using the split
pair.


> +                </goals>
> +              </execution>
> +            </executions>
> +          </plugin>
> +        </plugins>
> +      </build>
> +    </profile>
> +    <profile>
>       <id>maven-3</id>
>       <activation>
>         <file>
>
> Modified: maven/plugins/trunk/maven-plugins/src/site-docs/apt/index.apt
> URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-plugins/src/site-docs/apt/index.apt?rev=1142512&r1=1142511&r2=1142512&view=diff
> ==============================================================================
> --- maven/plugins/trunk/maven-plugins/src/site-docs/apt/index.apt (original)
> +++ maven/plugins/trunk/maven-plugins/src/site-docs/apt/index.apt Sun Jul  3 22:29:37 2011
> @@ -31,9 +31,11 @@ Maven Plugins Parent POM
>     This POM is the common parent of all of the Maven plugins
>     in the Apache Maven project.
>
> -    Every Maven plugin provide ITs (Integration Tests) to check real plugin execution.
> -    Nothing is defined in this parent POM about ITs since every project has its own requirements
> -    to run its ITs, but by convention, these ITs are defined by every plugin in a <<<run-its>>> profile:
> +The <<<run-its>>> Profile
> +
> +    This POM provides <<<run-its>>> profile for running Integration Tests to check real plugin execution.
> +    A default configuration for <<<maven-invoker-plugin>>> is defined, that every plugin needs to enhance
> +    to match its prerequisite. Then ITs are launched in every plugin with following command:
>
>  +---
>  mvn -Prun-its verify
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org