You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by "Carsten Ziegeler (Jira)" <ji...@apache.org> on 2022/05/21 11:33:00 UTC

[jira] [Commented] (SLING-11328) resource resolver: scales badly for duplicate vanity paths

    [ https://issues.apache.org/jira/browse/SLING-11328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540413#comment-17540413 ] 

Carsten Ziegeler commented on SLING-11328:
------------------------------------------

I'm not worried too much about this situation, in many cases there should only be occurance of a vanity path, in some situations maybe two.
The copying currently happens as there was no good concurrent collection when the code was written

> resource resolver: scales badly for duplicate vanity paths
> ----------------------------------------------------------
>
>                 Key: SLING-11328
>                 URL: https://issues.apache.org/jira/browse/SLING-11328
>             Project: Sling
>          Issue Type: Improvement
>          Components: ResourceResolver
>    Affects Versions: Resource Resolver 1.8.6
>            Reporter: Julian Reschke
>            Priority: Minor
>
> See <https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/52b8366e9b6e5ddff14b1ed340e780247b2d627a/src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java#L955-L976>:
> - upon add, new list is created, copied to, and then sorted
> Proposal:
> - avoid copying
> - avoid sorting over and over again during resolver startup



--
This message was sent by Atlassian Jira
(v8.20.7#820007)