You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/26 16:15:13 UTC

[GitHub] [arrow] zeroshade commented on a diff in pull request #14504: ARROW-17899: [Go][CSV] Add Decimal support to CSV reader

zeroshade commented on code in PR #14504:
URL: https://github.com/apache/arrow/pull/14504#discussion_r1005891754


##########
go/arrow/csv/reader_test.go:
##########
@@ -623,6 +625,48 @@ rec[0]["str"]: ["str-0" "str-1" "str-2" "str-3" "str-4" "str-5" "str-6" "str-7"
 	}
 }
 
+func TestReadCSVDecimalCols(t *testing.T) {
+	data := `dec128,dec256
+12.3,0.00123

Review Comment:
   good point, I'll bump it to precision 14 and add a call to `FitsInPrecision` to `FromString`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org