You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Pallav Kulshreshtha <pa...@gmail.com> on 2016/04/07 13:15:55 UTC
Review Request 45864: Hive view should have some checks before
starting similar to pig view
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45864/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary.
Bugs: AMBARI-15755
https://issues.apache.org/jira/browse/AMBARI-15755
Repository: ambari
Description
-------
- Added REST end points for hdfsStatus and atsStatus
- Consuming these REST end points in front end code to check services status on intermediate page.
- If everything passes then only we are taking to the landing page.
Diffs
-----
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/HelpService.java d581d9a
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/atsJobs/ATSRequestsDelegateImpl.java 041ab01
contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/splash.js PRE-CREATION
contrib/views/hive/src/main/resources/ui/hive-web/app/router.js 56e87d9
contrib/views/hive/src/main/resources/ui/hive-web/app/routes/application.js 916b7b3
contrib/views/hive/src/main/resources/ui/hive-web/app/routes/splash.js PRE-CREATION
contrib/views/hive/src/main/resources/ui/hive-web/app/templates/splash.hbs PRE-CREATION
Diff: https://reviews.apache.org/r/45864/diff/
Testing
-------
manually tested.
Thanks,
Pallav Kulshreshtha
Re: Review Request 45864: Hive view should have some checks before
starting similar to pig view
Posted by Rohit Choudhary <rc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45864/#review127589
-----------------------------------------------------------
Ship it!
Ship It!
- Rohit Choudhary
On April 7, 2016, 11:15 a.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45864/
> -----------------------------------------------------------
>
> (Updated April 7, 2016, 11:15 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary.
>
>
> Bugs: AMBARI-15755
> https://issues.apache.org/jira/browse/AMBARI-15755
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Added REST end points for hdfsStatus and atsStatus
> - Consuming these REST end points in front end code to check services status on intermediate page.
> - If everything passes then only we are taking to the landing page.
>
>
> Diffs
> -----
>
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/HelpService.java d581d9a
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/atsJobs/ATSRequestsDelegateImpl.java 041ab01
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/splash.js PRE-CREATION
> contrib/views/hive/src/main/resources/ui/hive-web/app/router.js 56e87d9
> contrib/views/hive/src/main/resources/ui/hive-web/app/routes/application.js 916b7b3
> contrib/views/hive/src/main/resources/ui/hive-web/app/routes/splash.js PRE-CREATION
> contrib/views/hive/src/main/resources/ui/hive-web/app/templates/splash.hbs PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45864/diff/
>
>
> Testing
> -------
>
> manually tested.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>
Re: Review Request 45864: Hive view should have some checks before
starting similar to pig view
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45864/#review127593
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On April 7, 2016, 11:15 a.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45864/
> -----------------------------------------------------------
>
> (Updated April 7, 2016, 11:15 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary.
>
>
> Bugs: AMBARI-15755
> https://issues.apache.org/jira/browse/AMBARI-15755
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Added REST end points for hdfsStatus and atsStatus
> - Consuming these REST end points in front end code to check services status on intermediate page.
> - If everything passes then only we are taking to the landing page.
>
>
> Diffs
> -----
>
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/HelpService.java d581d9a
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/atsJobs/ATSRequestsDelegateImpl.java 041ab01
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/splash.js PRE-CREATION
> contrib/views/hive/src/main/resources/ui/hive-web/app/router.js 56e87d9
> contrib/views/hive/src/main/resources/ui/hive-web/app/routes/application.js 916b7b3
> contrib/views/hive/src/main/resources/ui/hive-web/app/routes/splash.js PRE-CREATION
> contrib/views/hive/src/main/resources/ui/hive-web/app/templates/splash.hbs PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45864/diff/
>
>
> Testing
> -------
>
> manually tested.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>