[GitHub] [incubator-hudi] n3nash commented on a change in pull request #1119: Fix: HoodieCommitMetadata only show first commit insert rows.

[GitBox <gi...@apache.org>]

n3nash commented on a change in pull request #1119: Fix: HoodieCommitMetadata only show first commit insert rows.
URL: https://github.com/apache/incubator-hudi/pull/1119#discussion_r360986944
 
 

 ##########
 File path: hudi-common/src/main/java/org/apache/hudi/common/model/HoodieCommitMetadata.java
 ##########
 @@ -175,7 +175,9 @@ public long fetchTotalInsertRecordsWritten() {
     long totalInsertRecordsWritten = 0;
     for (List<HoodieWriteStat> stats : partitionToWriteStats.values()) {
       for (HoodieWriteStat stat : stats) {
-        if (stat.getPrevCommit() != null && stat.getPrevCommit().equalsIgnoreCase("null")) {
 
 Review comment:
   For the first commit, the prevCommmit value is actually "null" which is the reason why this check is here. 
   Can you inspect and see if stat.getPrevCommit() returns null in some cases ? Then, the above condition will not be satisfied.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services