You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by gi...@git.apache.org on 2017/09/04 22:46:06 UTC

[GitHub] tysonnorris commented on a change in pull request #2650: Apply standard scala formatting.

tysonnorris commented on a change in pull request #2650: Apply standard scala formatting.
URL: https://github.com/apache/incubator-openwhisk/pull/2650#discussion_r136874570
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/common/TransactionId.scala
 ##########
 @@ -25,7 +25,7 @@ import java.util.concurrent.atomic.AtomicInteger
 import scala.math.BigDecimal.int2bigDecimal
 import scala.util.Try
 
-import akka.event.Logging.{ InfoLevel, WarningLevel }
+import akka.event.Logging.{InfoLevel, WarningLevel}
 
 Review comment:
   Ok, ignoring wildcards, WDYT about changing these to separate imports? I think the `ExpandImportSelectors` rewrite in scalafmt will do it (while leaving wildcards alone) http://scalameta.org/scalafmt/#ExpandImportSelectors. 
   
   I think it will provide a good change to get imports formatted consistently (along with `SortedImported`).
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services