You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@sentry.apache.org by "Na Li (JIRA)" <ji...@apache.org> on 2018/09/12 03:59:00 UTC

[jira] [Assigned] (SENTRY-2185) Performance Issue: Saving MAuthzPathsMapping should be done in batch for path full snapshot

     [ https://issues.apache.org/jira/browse/SENTRY-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Na Li reassigned SENTRY-2185:
-----------------------------

    Assignee: Na Li

> Performance Issue: Saving MAuthzPathsMapping should be done in batch for path full snapshot
> -------------------------------------------------------------------------------------------
>
>                 Key: SENTRY-2185
>                 URL: https://issues.apache.org/jira/browse/SENTRY-2185
>             Project: Sentry
>          Issue Type: Bug
>          Components: Sentry
>    Affects Versions: 2.1.0
>            Reporter: Na Li
>            Assignee: Na Li
>            Priority: Major
>
> From the code below, for each MAuthzPathsMapping, there is a query to save each MAuthzPathsMapping instance. Need to save the changes in batch. 
> {code:java}
>   public void persistFullPathsImage(final Map<String, Collection<String>> authzPaths,
>       final long notificationID) throws Exception {
>     tm.executeTransactionWithRetry(
>             pm -> {
>               pm.setDetachAllOnCommit(false); // No need to detach objects
>               deleteNotificationsSince(pm, notificationID + 1);
>               // persist the notidicationID
>               pm.makePersistent(new MSentryHmsNotification(notificationID));
>               // persist the full snapshot
>               long snapshotID = getCurrentAuthzPathsSnapshotID(pm);
>               long nextSnapshotID = snapshotID + 1;
>               pm.makePersistent(new MAuthzPathsSnapshotId(nextSnapshotID));
>               LOGGER.info("Attempting to commit new HMS snapshot with ID = {}", nextSnapshotID);
>               for (Map.Entry<String, Collection<String>> authzPath : authzPaths.entrySet()) {
>                 pm.makePersistent(new MAuthzPathsMapping(nextSnapshotID, authzPath.getKey(), authzPath.getValue()));
>               }
>               return null;
>             });
>   }{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)