You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Joost Schouten (ml)" <jo...@jsportal.com> on 2009/12/05 16:00:23 UTC
Patch inclusion consideration
Hi,
Could one of the comitters have a look at the provided patch at:
https://issues.apache.org/jira/browse/TAP5-937 ?
Is it possible to get it included in T5.2.0-SNAPSHOT? It would remove
the need for me to build a custom version on every version update or new
developer deploy. And not to forget, it fixes a bug ;-)
Cheers,
Joost
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: Patch inclusion consideration
Posted by "Joost Schouten (ml)" <jo...@jsportal.com>.
> The URL rewrite code instantiates LinkImpl's in a very ordinary way.
> It uses relative paths when the rewritten URL belongs to the same
> server as the original and a absolute one when the server name was
> changed. I guess the problem, as you described, is how LinkImpl deals
> with setting query parameters.
I thought that maybe the URL rewiter should detect any already available
parameters and add them again the usual way though addParameter. But I
guess that comes down to personal preference. I like (as per your
suggestion) the LinkImpl to be a bit more clever and fix the problem
like in my patch.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: Patch inclusion consideration
Posted by "Thiago H. de Paula Figueiredo" <th...@gmail.com>.
Em Tue, 08 Dec 2009 06:45:18 -0200, Joost Schouten (ml)
<jo...@jsportal.com> escreveu:
> That'd be great. Thanks a lot and keep me posted if another solution
> would be preferable. I can imagine that maybe some work could be done on
> the way the URL rewrite stuff instantiates the LinkImpl's.
The URL rewrite code instantiates LinkImpl's in a very ordinary way. It
uses relative paths when the rewritten URL belongs to the same server as
the original and a absolute one when the server name was changed. I guess
the problem, as you described, is how LinkImpl deals with setting query
parameters.
--
Thiago H. de Paula Figueiredo
Independent Java, Apache Tapestry 5 and Hibernate consultant, developer,
and instructor
Owner, software architect and developer, Ars Machina Tecnologia da
Informação Ltda.
http://www.arsmachina.com.br
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: Patch inclusion consideration
Posted by "Joost Schouten (ml)" <jo...@jsportal.com>.
That'd be great. Thanks a lot and keep me posted if another solution
would be preferable. I can imagine that maybe some work could be done on
the way the URL rewrite stuff instantiates the LinkImpl's.
Cheers,
Joost
Robert Zeigler wrote:
> I'll take a look at it, once I've closed my other ticket(s).
>
> Robert
>
> On Dec 5, 2009, at 12/59:00 AM , Joost Schouten (ml) wrote:
>
>> Hi,
>>
>> Could one of the comitters have a look at the provided patch at:
>> https://issues.apache.org/jira/browse/TAP5-937 ?
>>
>> Is it possible to get it included in T5.2.0-SNAPSHOT? It would remove
>> the need for me to build a custom version on every version update or
>> new developer deploy. And not to forget, it fixes a bug ;-)
>>
>> Cheers,
>> Joost
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
>> For additional commands, e-mail: dev-help@tapestry.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: Patch inclusion consideration
Posted by Robert Zeigler <ro...@scazdl.org>.
I'll take a look at it, once I've closed my other ticket(s).
Robert
On Dec 5, 2009, at 12/59:00 AM , Joost Schouten (ml) wrote:
> Hi,
>
> Could one of the comitters have a look at the provided patch at: https://issues.apache.org/jira/browse/TAP5-937
> ?
>
> Is it possible to get it included in T5.2.0-SNAPSHOT? It would
> remove the need for me to build a custom version on every version
> update or new developer deploy. And not to forget, it fixes a bug ;-)
>
> Cheers,
> Joost
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org