You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/11 11:09:20 UTC
[GitHub] [incubator-doris] 924060929 commented on a diff in pull request #9506: [Feature](Nereids) Data structure of comparison predicate
924060929 commented on code in PR #9506:
URL: https://github.com/apache/incubator-doris/pull/9506#discussion_r870168998
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/pattern/Patterns.java:
##########
@@ -329,33 +328,31 @@ default PatternDescriptor<SlotReference, Expression> slotReference() {
}
/**
- * create a binaryPredicate pattern.
+ * TODO create a ComparisonPredicate pattern.
*/
- default PatternDescriptor<BinaryPredicate<Expression, Expression>, Expression> binaryPredicate() {
- return new PatternDescriptor<>(
- new Pattern<>(NodeType.BINARY_PREDICATE),
- defaultPromise()
- );
- }
/**
- * create a binaryPredicate pattern with operator type.
+ * TODO create a ComparisonPredicate pattern with children patterns.
*/
- default PatternDescriptor<BinaryPredicate<Expression, Expression>, Expression> binaryPredicate(Operator operator) {
- return new PatternDescriptor<BinaryPredicate<Expression, Expression>, Expression>(
- new Pattern<>(NodeType.BINARY_PREDICATE),
+
+ /**
+ * create a equal to predicate pattern.
+ */
+ default PatternDescriptor<EqualTo<Expression, Expression>, Expression> eqcomparisonPredicate() {
+ return new PatternDescriptor<>(
+ new Pattern<>(NodeType.EQ_COMPARISON_PREDICATE),
defaultPromise()
- ).when(p -> p.getOperator() == operator);
+ );
}
/**
- * create a binaryPredicate pattern with children patterns.
+ * create a equal to predicate pattern with children patterns.
*/
- default <C1 extends Expression, C2 extends Expression> PatternDescriptor<BinaryPredicate<C1, C2>, Expression>
- binaryPredicate(PatternDescriptor<C1, Expression> leftChildPattern,
+ default <C1 extends Expression, C2 extends Expression> PatternDescriptor<EqualTo<C1, C2>, Expression>
+ eqcomparisonPredicate(PatternDescriptor<C1, Expression> leftChildPattern,
Review Comment:
```suggestion
equalsTo(PatternDescriptor<C1, Expression> leftChildPattern,
```
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/pattern/Patterns.java:
##########
@@ -329,33 +328,31 @@ default PatternDescriptor<SlotReference, Expression> slotReference() {
}
/**
- * create a binaryPredicate pattern.
+ * TODO create a ComparisonPredicate pattern.
*/
- default PatternDescriptor<BinaryPredicate<Expression, Expression>, Expression> binaryPredicate() {
- return new PatternDescriptor<>(
- new Pattern<>(NodeType.BINARY_PREDICATE),
- defaultPromise()
- );
- }
/**
- * create a binaryPredicate pattern with operator type.
+ * TODO create a ComparisonPredicate pattern with children patterns.
*/
- default PatternDescriptor<BinaryPredicate<Expression, Expression>, Expression> binaryPredicate(Operator operator) {
- return new PatternDescriptor<BinaryPredicate<Expression, Expression>, Expression>(
- new Pattern<>(NodeType.BINARY_PREDICATE),
+
+ /**
+ * create a equal to predicate pattern.
+ */
+ default PatternDescriptor<EqualTo<Expression, Expression>, Expression> eqcomparisonPredicate() {
Review Comment:
```suggestion
default PatternDescriptor<EqualTo<Expression, Expression>, Expression> equalsTo() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org