[jira] [Commented] (AIRFLOW-3311) Allow Pod Operator to Retain Failed Pods

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679791#comment-16679791 ] 

ASF GitHub Bot commented on AIRFLOW-3311:
-----------------------------------------

EamonKeane opened a new pull request #4160: [AIRFLOW-3311] Allow pod operator to keep failed pods
URL: https://github.com/apache/incubator-airflow/pull/4160
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ✔] My PR addresses the following [Airflow Jira]
   
   [AIRFLOW-3311] Allow pod operator to keep failed pods
   https://issues.apache.org/jira/browse/AIRFLOW-3311?jql=text%20~%20%22keep%20failed%20pod%22
   
   ### Description
   
   - [✔ ] Here are some details about my PR, including screenshots of any UI changes:
   Extends AIRFLOW-2854 to enable keeping of pods with non-zero exit codes for log inspection in kubernetes clusters.
   
   ### Tests
   
   - [✔ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   tests/contrib/minikube/test_kubernetes_pod_operator.py:
   test_keep_failed_pod()
   
   ### Commits
   
   - [✔ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [✔ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
   
   ### Code Quality
   
   - [✔ ] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Allow Pod Operator to Retain Failed Pods
> ----------------------------------------
>
>                 Key: AIRFLOW-3311
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3311
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: contrib
>    Affects Versions: 2.0.0
>            Reporter: Eamon Keane
>            Assignee: Eamon Keane
>            Priority: Minor
>
> When using the pod operator it is convenient to be able to retain failed pods for log inspectionl
> Airflow 2854 introduced the ability to delete pods made with the pod operator, however it only has configuration to allow you to delete all pods.
> This extends Airflow 2854 to allow the user to specify a flag to keep pods that exit with a non-zero exit code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)