You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "dannycjones (via GitHub)" <gi...@apache.org> on 2026/06/30 08:38:18 UTC

[PR] chore(ci): Remove '--locked' flag on toml-cli install [iceberg-rust]

dannycjones opened a new pull request, #2750:
URL: https://github.com/apache/iceberg-rust/pull/2750

   ## Which issue does this PR close?
   
   N/A
   
   ## What changes are included in this PR?
   
   We moved all CLI installs to `--locked` in #2739. Unfortunately, this doesn't work for `toml-cli` as it is not regularly updated and its lock file refers to outdated dependencies. In particular, it points to crates which use nightly unstable features which no longer exist.
   
   This change removes `--locked` and adds a comment to explain why.
   
   Alternatively, we could use the stable toolchain here although I think it's OK to use newer dependencies instead.
   
   ## Are these changes tested?
   
   Manually tested, the following command succeeds:
   
   ```
   cargo +nightly-2026-03-05 install toml-cli --force
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] chore(ci): Remove '--locked' flag on toml-cli install [iceberg-rust]

Posted by "dannycjones (via GitHub)" <gi...@apache.org>.
dannycjones commented on PR #2750:
URL: https://github.com/apache/iceberg-rust/pull/2750#issuecomment-4841475079

   FYI @CTTY 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] chore(ci): Remove '--locked' flag on toml-cli install [iceberg-rust]

Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu merged PR #2750:
URL: https://github.com/apache/iceberg-rust/pull/2750


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org