You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/07/30 07:25:44 UTC

[GitHub] [hive] mustafaiman opened a new pull request #1337: HIVE-23952:

mustafaiman opened a new pull request #1337:
URL: https://github.com/apache/hive/pull/1337


   Change-Id: If398aba0130fffff28c17d18340c20ba681c278f
   
   ## NOTICE
   
   Please create an issue in ASF JIRA before opening a pull request,
   and you need to set the title of the pull request which starts with
   the corresponding JIRA issue number. (e.g. HIVE-XXXXX: Fix a typo in YYY)
   For more details, please see https://cwiki.apache.org/confluence/display/Hive/HowToContribute
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] rbalamohan commented on a change in pull request #1337: HIVE-23952: Reuse VectorAggregationBuffer to reduce GC pressure in VectorGroupByOperator

Posted by GitBox <gi...@apache.org>.
rbalamohan commented on a change in pull request #1337:
URL: https://github.com/apache/hive/pull/1337#discussion_r465386334



##########
File path: ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorGroupByOperator.java
##########
@@ -21,6 +21,10 @@
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertTrue;
+import static org.mockito.Mockito.atMost;

Review comment:
       May not be needed?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] mustafaiman closed pull request #1337: HIVE-23952: Reuse VectorAggregationBuffer to reduce GC pressure in VectorGroupByOperator

Posted by GitBox <gi...@apache.org>.
mustafaiman closed pull request #1337:
URL: https://github.com/apache/hive/pull/1337


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] mustafaiman commented on a change in pull request #1337: HIVE-23952: Reuse VectorAggregationBuffer to reduce GC pressure in VectorGroupByOperator

Posted by GitBox <gi...@apache.org>.
mustafaiman commented on a change in pull request #1337:
URL: https://github.com/apache/hive/pull/1337#discussion_r465387373



##########
File path: ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorGroupByOperator.java
##########
@@ -21,6 +21,10 @@
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertTrue;
+import static org.mockito.Mockito.atMost;

Review comment:
       fixed. thanks.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org