You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by bc...@apache.org on 2017/05/13 00:14:24 UTC

[trafficserver] branch master updated: coverity 1021707: Uninitialized scalar field

This is an automated email from the ASF dual-hosted git repository.

bcall pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git

The following commit(s) were added to refs/heads/master by this push:
       new  6693f58   coverity 1021707: Uninitialized scalar field
6693f58 is described below

commit 6693f58ef9c2392167cb99b103460efd3812de5b
Author: Bryan Call <bc...@apache.org>
AuthorDate: Thu May 11 17:39:50 2017 -0400

    coverity 1021707: Uninitialized scalar field
---
 proxy/RegressionSM.h | 39 +++++++++++++--------------------------
 1 file changed, 13 insertions(+), 26 deletions(-)

diff --git a/proxy/RegressionSM.h b/proxy/RegressionSM.h
index 75513fa..ddb4c85 100644
--- a/proxy/RegressionSM.h
+++ b/proxy/RegressionSM.h
@@ -35,7 +35,7 @@
 */
 
 struct RegressionSM : public Continuation {
-  RegressionTest *t; // for use with rprint
+  RegressionTest *t = nullptr; // for use with rprint
 
   // methods to override
   virtual void run(); // replace with leaf regression
@@ -51,16 +51,17 @@ struct RegressionSM : public Continuation {
   void run_in(int *pstatus, ink_hrtime t);
 
   // internal
-  int status;
-  int *pstatus;
-  RegressionSM *parent;
-  int nwaiting;
-  int nchildren;
-  DynArray<RegressionSM *> children;
-  intptr_t n, ichild;
-  bool parallel;
-  bool repeat;
-  Action *pending_action;
+  int status                        = REGRESSION_TEST_INPROGRESS;
+  int *pstatus                      = nullptr;
+  RegressionSM *parent              = nullptr;
+  int nwaiting                      = 0;
+  int nchildren                     = 0;
+  DynArray<RegressionSM *> children = nullptr;
+  intptr_t n                        = 0;
+  intptr_t ichild                   = 0;
+  bool parallel                     = false;
+  bool repeat                       = false;
+  Action *pending_action            = nullptr;
 
   int regression_sm_start(int event, void *data);
   int regression_sm_waiting(int event, void *data);
@@ -68,21 +69,7 @@ struct RegressionSM : public Continuation {
   void child_done(int status);
   void xrun(RegressionSM *parent);
 
-  RegressionSM(RegressionTest *at = NULL)
-    : t(at),
-      status(REGRESSION_TEST_INPROGRESS),
-      pstatus(0),
-      parent(0),
-      nwaiting(0),
-      nchildren(0),
-      children(0),
-      ichild(0),
-      parallel(false),
-      repeat(false),
-      pending_action(0)
-  {
-    mutex = new_ProxyMutex();
-  }
+  RegressionSM(RegressionTest *at = NULL) : t(at) { mutex = new_ProxyMutex(); }
 
   RegressionSM(const RegressionSM &);
 };

-- 
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" <co...@trafficserver.apache.org>'].