You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by tr...@apache.org on 2016/03/24 22:23:00 UTC
svn commit: r1736510 - /httpd/httpd/branches/2.4.x/STATUS
Author: trawick
Date: Thu Mar 24 21:23:00 2016
New Revision: 1736510
URL: http://svn.apache.org/viewvc?rev=1736510&view=rev
Log:
HTTP_BAD_GATEWAY -> MODSSL_ERROR_BAD_GATEWAY
Modified:
httpd/httpd/branches/2.4.x/STATUS
Modified: httpd/httpd/branches/2.4.x/STATUS
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1736510&r1=1736509&r2=1736510&view=diff
==============================================================================
--- httpd/httpd/branches/2.4.x/STATUS (original)
+++ httpd/httpd/branches/2.4.x/STATUS Thu Mar 24 21:23:00 2016
@@ -177,6 +177,11 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
Bad Jeff: The MMN change was missing originally, same patch updated :(
+1: trawick, ylavic
+ *) mod_ssl: Return 502 instead of 500 when SSL peer check or
+ proxy_post_handshake hook fails.
+ Trunk patch: r1645529 (works)
+ 2.4.x patch which adds CHANGES: https://emptyhammock.com/media/downloads/r1645529-to-2.4.x.txt
+ +1: trawick
PATCHES/ISSUES THAT ARE BEING WORKED
Re: svn commit: r1736510 - /httpd/httpd/branches/2.4.x/STATUS
Posted by Jeff Trawick <tr...@gmail.com>.
On Tue, Mar 29, 2016 at 12:22 PM, Yann Ylavic <yl...@gmail.com> wrote:
> On Thu, Mar 24, 2016 at 10:23 PM, <tr...@apache.org> wrote:
> > Author: trawick
> > Date: Thu Mar 24 21:23:00 2016
> > New Revision: 1736510
> >
> > URL: http://svn.apache.org/viewvc?rev=1736510&view=rev
> > Log:
> > HTTP_BAD_GATEWAY -> MODSSL_ERROR_BAD_GATEWAY
> >
> > Modified:
> > httpd/httpd/branches/2.4.x/STATUS
> >
> > + *) mod_ssl: Return 502 instead of 500 when SSL peer check or
> > + proxy_post_handshake hook fails.
> > + Trunk patch: r1645529 (works)
> > + 2.4.x patch which adds CHANGES:
> https://emptyhammock.com/media/downloads/r1645529-to-2.4.x.txt
> > + +1: trawick
>
> In 2.4.x (not trunk), ssl_io_filter_error() seems to finally create an
> HTTP_BAD_REQUEST error bucket for the MODSSL_ERROR_BAD_GATEWAY case,
> shouldn't we also backport r1416589?
>
Something is happening in trunk that causes 500 to be returned when an
error is returned in that area of code. I'll try to debug that soon, as
the answer for further trunk sync depends on which part of trunk is
resulting in 500 :)
--
Born in Roswell... married an alien...
http://emptyhammock.com/
Re: svn commit: r1736510 - /httpd/httpd/branches/2.4.x/STATUS
Posted by Yann Ylavic <yl...@gmail.com>.
On Thu, Mar 24, 2016 at 10:23 PM, <tr...@apache.org> wrote:
> Author: trawick
> Date: Thu Mar 24 21:23:00 2016
> New Revision: 1736510
>
> URL: http://svn.apache.org/viewvc?rev=1736510&view=rev
> Log:
> HTTP_BAD_GATEWAY -> MODSSL_ERROR_BAD_GATEWAY
>
> Modified:
> httpd/httpd/branches/2.4.x/STATUS
>
> + *) mod_ssl: Return 502 instead of 500 when SSL peer check or
> + proxy_post_handshake hook fails.
> + Trunk patch: r1645529 (works)
> + 2.4.x patch which adds CHANGES: https://emptyhammock.com/media/downloads/r1645529-to-2.4.x.txt
> + +1: trawick
In 2.4.x (not trunk), ssl_io_filter_error() seems to finally create an
HTTP_BAD_REQUEST error bucket for the MODSSL_ERROR_BAD_GATEWAY case,
shouldn't we also backport r1416589?