You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Karl Fogel <kf...@newton.ch.collab.net> on 2002/07/11 15:23:05 UTC

Re: svn commit: rev 2464

cmpilato@tigris.org writes:
> Author: cmpilato
> Date: Wed, 10 Jul 2002 17:04:58 -0500
> New Revision: 2464
>
> --- branches/issue-745-dev/subversion/include/svn_fs.h	(original)
> +++ branches/issue-745-dev/subversion/include/svn_fs.h	Wed Jul 10 17:05:02 2002
> @@ -557,7 +557,8 @@
>    svn_fs_path_change_modify = 0,
>    svn_fs_path_change_add,
>    svn_fs_path_change_delete,
> -  svn_fs_path_change_replace
> +  svn_fs_path_change_replace,
> +  svn_fs_path_change_reset
>  
>  } svn_fs_path_change_kind_t;

Just a thought:

Suggest documenting the meanings of these enums, especially now that
`reset' has been added.  It may not be immediately clear to the casual
reader what they mean.  And then in svn_fs_path_change_t, document the
meanings of the fields, and when certain fields can be null, etc...

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org