You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2017/02/21 19:44:19 UTC
svn commit: r1783920 - in /jmeter/trunk:
src/protocol/http/org/apache/jmeter/protocol/http/proxy/AbstractSamplerCreator.java
src/protocol/http/org/apache/jmeter/protocol/http/proxy/DefaultSamplerCreator.java
xdocs/changes.xml
Author: pmouawad
Date: Tue Feb 21 19:44:19 2017
New Revision: 1783920
URL: http://svn.apache.org/viewvc?rev=1783920&view=rev
Log:
Bug 60758 - HTTP(s) Test Script Recorder : Number request may generate duplicate numbers
Bugzilla Id: 60758
Modified:
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/AbstractSamplerCreator.java
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/DefaultSamplerCreator.java
jmeter/trunk/xdocs/changes.xml
Modified: jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/AbstractSamplerCreator.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/AbstractSamplerCreator.java?rev=1783920&r1=1783919&r2=1783920&view=diff
==============================================================================
--- jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/AbstractSamplerCreator.java (original)
+++ jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/AbstractSamplerCreator.java Tue Feb 21 19:44:19 2017
@@ -94,7 +94,15 @@ public abstract class AbstractSamplerCre
* Increment request number
*/
protected static void incrementRequestNumber() {
- REQUEST_NUMBER.incrementAndGet();
+ incrementRequestNumberAndGet();
+ }
+
+ /**
+ * Increment request number
+ * @return int number for created sampler
+ */
+ protected static int incrementRequestNumberAndGet() {
+ return REQUEST_NUMBER.incrementAndGet();
}
/**
Modified: jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/DefaultSamplerCreator.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/DefaultSamplerCreator.java?rev=1783920&r1=1783919&r2=1783920&view=diff
==============================================================================
--- jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/DefaultSamplerCreator.java (original)
+++ jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/DefaultSamplerCreator.java Tue Feb 21 19:44:19 2017
@@ -275,8 +275,7 @@ public class DefaultSamplerCreator exten
protected void computeSamplerName(HTTPSamplerBase sampler,
HttpRequestHdr request) {
if (!HTTPConstants.CONNECT.equals(request.getMethod()) && isNumberRequests()) {
- incrementRequestNumber();
- sampler.setName(getRequestNumber() + " " + sampler.getPath());
+ sampler.setName(incrementRequestNumberAndGet() + " " + sampler.getPath());
} else {
sampler.setName(sampler.getPath());
}
Modified: jmeter/trunk/xdocs/changes.xml
URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1783920&r1=1783919&r2=1783920&view=diff
==============================================================================
--- jmeter/trunk/xdocs/changes.xml [utf-8] (original)
+++ jmeter/trunk/xdocs/changes.xml [utf-8] Tue Feb 21 19:44:19 2017
@@ -240,6 +240,7 @@ JMeter now requires Java 8. Ensure you u
<li><bug>60652</bug>PUT might leak file descriptors.</li>
<li><bug>60689</bug><code>httpclient4.validate_after_inactivity</code> has no impact leading to usage of potentially stale/closed connections</li>
<li><bug>60690</bug>Default values for "httpclient4.validate_after_inactivity" and "httpclient4.time_to_live" which are equal to each other makes validation useless</li>
+ <li><bug>60758</bug>HTTP(s) Test Script Recorder : Number request may generate duplicate numbers. Contributed by Ubik Load Pack (support at ubikloadpack.com)</li>
</ul>
<h3>Other Samplers</h3>