You are viewing a plain text version of this content. The canonical link for it is here.

Posted to ojb-dev@db.apache.org by "Robert S. Sfeir" <ro...@codepuccino.com> on 2003/12/13 04:20:01 UTC

[PATCH] Boolean and Redundant Cast Fixes

Would one of the commiters be so kind and check in the patches from the link below?

http://www.codepuccino.com/patches.txt

I think this time I did the patching right.  Hopefuly this can make it in,
and I can submit more later.  The file is big because some of the changes to 2 files required removing
an import, which shifted all the lines up.  Sorry if I wasn't supposed to do that.

R

Re: [PATCH] Boolean and Redundant Cast Fixes

Posted by "Robert S. Sfeir" <ro...@codepuccino.com>.

Thanks!

I'll check out the code again, and now clean up the system debug calls 
and turn them into cleaned up ifDebugEnabled... calls...  couple of days.

R

Thomas Mahler wrote:

> Hi Robert,
>
> thanks for the patch. It's now applied to CVS.
> I did not apply the changes to the generated OQL parser code.
> won't make much sense to change it as it will be overwritten by the 
> next run of the parser generator...
>
> cheers,
> Thomas
>
> Robert S. Sfeir wrote:
>
>> Would one of the commiters be so kind and check in the patches from 
>> the link below?
>>
>> http://www.codepuccino.com/patches.txt
>>
>> I think this time I did the patching right.  Hopefuly this can make 
>> it in,
>> and I can submit more later.  The file is big because some of the 
>> changes to 2 files required removing
>> an import, which shifted all the lines up.  Sorry if I wasn't 
>> supposed to do that.
>>
>> R
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
> For additional commands, e-mail: ojb-dev-help@db.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org

Re: [PATCH] Boolean and Redundant Cast Fixes

Posted by Thomas Mahler <th...@web.de>.

Hi Robert,

thanks for the patch. It's now applied to CVS.
I did not apply the changes to the generated OQL parser code.
won't make much sense to change it as it will be overwritten by the next 
run of the parser generator...

cheers,
Thomas

Robert S. Sfeir wrote:
> Would one of the commiters be so kind and check in the patches from the link below?
> 
> http://www.codepuccino.com/patches.txt
> 
> I think this time I did the patching right.  Hopefuly this can make it in,
> and I can submit more later.  The file is big because some of the changes to 2 files required removing
> an import, which shifted all the lines up.  Sorry if I wasn't supposed to do that.
> 
> R



---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org