You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by "Robert Scholte (JIRA)" <ji...@apache.org> on 2018/10/31 16:47:00 UTC

[jira] [Closed] (MSHADE-303) Suppress module-info.class warning if the file if filtered

     [ https://issues.apache.org/jira/browse/MSHADE-303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Scholte closed MSHADE-303.
---------------------------------
       Resolution: Fixed
    Fix Version/s: 3.2.1

Fixed in [1f7f25d2ce4391741fab36d18b61a69637f46bc3|https://gitbox.apache.org/repos/asf?p=maven-shade-plugin.git;a=commit;h=1f7f25d2ce4391741fab36d18b61a69637f46bc3]
Thanks for the patch!

> Suppress module-info.class warning if the file if filtered
> ----------------------------------------------------------
>
>                 Key: MSHADE-303
>                 URL: https://issues.apache.org/jira/browse/MSHADE-303
>             Project: Maven Shade Plugin
>          Issue Type: Improvement
>    Affects Versions: 3.2.0
>            Reporter: Danila
>            Assignee: Robert Scholte
>            Priority: Major
>             Fix For: 3.2.1
>
>
> Maven always shows “Discovered module-info.class. Shading will break its strong encapsulation.” warning, even then the user has explicitly filtered those files out. The same with “META-INF/INDEX.LIST” file.
> I am going to issue a [pull request|https://github.com/apache/maven-shade-plugin/pull/8] to fix this by applying file filters BEFORE these built-in warning checkers.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)