You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shenyu.apache.org by David Liu <he...@apache.org> on 2021/07/28 14:13:09 UTC
shenyu admin test coverage improvement
Hi,
Below is the class that need to improve test coverage in shenyu-admin
module.
org.apache.shenyu.admin.service.impl.DataPermissionServiceImpl(0%)
org.apache.shenyu.admin.service.impl.SelectorServiceImpl(46%)
org.apache.shenyu.admin.service.impl.UpstreamCheckService(60%)
org.apache.shenyu.admin.service.impl.DashboardUserServiceImpl(66%)
org.apache.shenyu.admin.service.impl.RuleServiceImpl(75%)
org.apache.shenyu.admin.service.impl.MetaDataServiceImpl(81%)
org.apache.shenyu.admin.service.impl.PermissionServiceImpl(62%)
org.apache.shenyu.admin.service.register.ShenyuClientRegisterSpringCloudServiceImpl(6%)
org.apache.shenyu.admin.service.register.AbstractShenyuClientRegisterServiceImpl.AbstractShenyuClientRegisterServiceImpl(1%)
org.apache.shenyu.admin.service.register.ShenyuClientRegisterSpringMVCServiceImpl(9%)
org.apache.shenyu.admin.service.register.ShenyuClientRegisterSofaServiceImpl(14%)
org.apache.shenyu.admin.service.register.ShenyuClientRegisterDubboServiceImpl(17%)
org.apache.shenyu.admin.service.register.ShenyuClientRegisterTarsServiceImpl(15%)
org.apache.shenyu.admin.service.register.ShenyuClientRegisterDefaultServiceImpl(14%)
org.apache.shenyu.admin.service.register.ShenyuClientRegisterMotanServiceImpl(18%)
org.apache.shenyu.admin.service.register.ShenyuClientRegisterGrpcServiceImpl(18%)
org.apache.shenyu.admin.listener.http.HttpLongPollingDataChangedListener(7%)
org.apache.shenyu.admin.listener.http.HttpLongPollingDataChangedListener.DataChangeTask(0%)
org.apache.shenyu.admin.listener.http.HttpLongPollingDataChangedListener.LongPollingClient(0%)
org.apache.shenyu.admin.listener.AbstractDataChangedListener(3%)
org.apache.shenyu.admin.listener.ConfigDataCache(0%)
org.apache.shenyu.admin.listener.ConfigDataCache(0%)
org.apache.shenyu.admin.listener.zookeeper.HttpServiceDiscovery(7%)
org.apache.shenyu.admin.exception.ExceptionHandlers(18%)
org.apache.shenyu.admin.config.LdapConfiguration(0%)
org.apache.shenyu.admin.config.DataSyncConfiguration(0%)
org.apache.shenyu.admin.config.ConsulServerConfiguration(0%)
org.apache.shenyu.admin.config.DataBaseConfiguration(0%)
org.apache.shenyu.admin.shiro.bean.StatelessAuthFilter(6%)
org.apache.shenyu.admin.shiro.bean.StatelessToken(0%)
org.apache.shenyu.admin.listener.websocket.WebsocketListener(10%)
org.apache.shenyu.admin.listener.websocket.WebsocketConfigurator(28%)
org.apache.shenyu.admin.shiro.config.ShiroRealm(0%)
org.apache.shenyu.admin.disruptor.subscriber.URIRegisterExecutorSubscriber(12%)
org.apache.shenyu.admin.disruptor.subscriber.MetadataExecutorSubscriber(60%)
org.apache.shenyu.admin.aspect.DataPermissionAspect(8%)
each line has record a class and the current test coverage is in the brackets
at end of line.
I post the statistic via the jacoco plugin in the maven test lifetime (you
can use mvn test in your local repository, then you can get the result in
maven generate target directory which named site/jacoco, the code coverage
will be present in the static web page index.html).
We hope more developer to participant to impove test coverage.
Re: shenyu admin test coverage improvement
Posted by David Liu <he...@apache.org>.
Please comment on this issue shenyu-admin module test coverage improvement
· Issue #1824 · apache/incubator-shenyu (github.com)
<https://github.com/apache/incubator-shenyu/issues/1824>
Kunshuai Zhu <jo...@gmail.com> 于2021年7月28日周三 下午10:19写道：
> Hi, I would like to improve test coverage of
> `org.apache.shenyu.admin.service.impl.*`
>
> David Liu <he...@apache.org> 于2021年7月28日周三 下午10:13写道：
> >
> > Hi,
> > Below is the class that need to improve test coverage in shenyu-admin
> > module.
> >
> > org.apache.shenyu.admin.service.impl.DataPermissionServiceImpl(0%)
> > org.apache.shenyu.admin.service.impl.SelectorServiceImpl(46%)
> > org.apache.shenyu.admin.service.impl.UpstreamCheckService(60%)
> > org.apache.shenyu.admin.service.impl.DashboardUserServiceImpl(66%)
> > org.apache.shenyu.admin.service.impl.RuleServiceImpl(75%)
> > org.apache.shenyu.admin.service.impl.MetaDataServiceImpl(81%)
> > org.apache.shenyu.admin.service.impl.PermissionServiceImpl(62%)
> >
> org.apache.shenyu.admin.service.register.ShenyuClientRegisterSpringCloudServiceImpl(6%)
> >
> org.apache.shenyu.admin.service.register.AbstractShenyuClientRegisterServiceImpl.AbstractShenyuClientRegisterServiceImpl(1%)
> >
> org.apache.shenyu.admin.service.register.ShenyuClientRegisterSpringMVCServiceImpl(9%)
> >
> org.apache.shenyu.admin.service.register.ShenyuClientRegisterSofaServiceImpl(14%)
> >
> org.apache.shenyu.admin.service.register.ShenyuClientRegisterDubboServiceImpl(17%)
> >
> org.apache.shenyu.admin.service.register.ShenyuClientRegisterTarsServiceImpl(15%)
> >
> org.apache.shenyu.admin.service.register.ShenyuClientRegisterDefaultServiceImpl(14%)
> >
> org.apache.shenyu.admin.service.register.ShenyuClientRegisterMotanServiceImpl(18%)
> >
> org.apache.shenyu.admin.service.register.ShenyuClientRegisterGrpcServiceImpl(18%)
> >
> org.apache.shenyu.admin.listener.http.HttpLongPollingDataChangedListener(7%)
> >
> org.apache.shenyu.admin.listener.http.HttpLongPollingDataChangedListener.DataChangeTask(0%)
> >
> org.apache.shenyu.admin.listener.http.HttpLongPollingDataChangedListener.LongPollingClient(0%)
> > org.apache.shenyu.admin.listener.AbstractDataChangedListener(3%)
> > org.apache.shenyu.admin.listener.ConfigDataCache(0%)
> > org.apache.shenyu.admin.listener.ConfigDataCache(0%)
> > org.apache.shenyu.admin.listener.zookeeper.HttpServiceDiscovery(7%)
> > org.apache.shenyu.admin.exception.ExceptionHandlers(18%)
> > org.apache.shenyu.admin.config.LdapConfiguration(0%)
> > org.apache.shenyu.admin.config.DataSyncConfiguration(0%)
> > org.apache.shenyu.admin.config.ConsulServerConfiguration(0%)
> > org.apache.shenyu.admin.config.DataBaseConfiguration(0%)
> > org.apache.shenyu.admin.shiro.bean.StatelessAuthFilter(6%)
> > org.apache.shenyu.admin.shiro.bean.StatelessToken(0%)
> > org.apache.shenyu.admin.listener.websocket.WebsocketListener(10%)
> > org.apache.shenyu.admin.listener.websocket.WebsocketConfigurator(28%)
> > org.apache.shenyu.admin.shiro.config.ShiroRealm(0%)
> >
> org.apache.shenyu.admin.disruptor.subscriber.URIRegisterExecutorSubscriber(12%)
> >
> org.apache.shenyu.admin.disruptor.subscriber.MetadataExecutorSubscriber(60%)
> > org.apache.shenyu.admin.aspect.DataPermissionAspect(8%)
> >
> > each line has record a class and the current test coverage is in the
> brackets
> > at end of line.
> >
> > I post the statistic via the jacoco plugin in the maven test lifetime
> (you
> > can use mvn test in your local repository, then you can get the result in
> > maven generate target directory which named site/jacoco, the code
> coverage
> > will be present in the static web page index.html).
> >
> > We hope more developer to participant to impove test coverage.
>
Re: shenyu admin test coverage improvement
Posted by David Liu <he...@apache.org>.
>
> shenyu-admin module test coverage improvement · Issue #1824 ·
> apache/incubator-shenyu (github.com)
> <https://github.com/apache/incubator-shenyu/issues/1824>
Welcome to comment which part you want to participant.
Re: shenyu admin test coverage improvement
Posted by Kunshuai Zhu <jo...@gmail.com>.
Hi, I would like to improve test coverage of
`org.apache.shenyu.admin.service.impl.*`
David Liu <he...@apache.org> 于2021年7月28日周三 下午10:13写道：
>
> Hi,
> Below is the class that need to improve test coverage in shenyu-admin
> module.
>
> org.apache.shenyu.admin.service.impl.DataPermissionServiceImpl(0%)
> org.apache.shenyu.admin.service.impl.SelectorServiceImpl(46%)
> org.apache.shenyu.admin.service.impl.UpstreamCheckService(60%)
> org.apache.shenyu.admin.service.impl.DashboardUserServiceImpl(66%)
> org.apache.shenyu.admin.service.impl.RuleServiceImpl(75%)
> org.apache.shenyu.admin.service.impl.MetaDataServiceImpl(81%)
> org.apache.shenyu.admin.service.impl.PermissionServiceImpl(62%)
> org.apache.shenyu.admin.service.register.ShenyuClientRegisterSpringCloudServiceImpl(6%)
> org.apache.shenyu.admin.service.register.AbstractShenyuClientRegisterServiceImpl.AbstractShenyuClientRegisterServiceImpl(1%)
> org.apache.shenyu.admin.service.register.ShenyuClientRegisterSpringMVCServiceImpl(9%)
> org.apache.shenyu.admin.service.register.ShenyuClientRegisterSofaServiceImpl(14%)
> org.apache.shenyu.admin.service.register.ShenyuClientRegisterDubboServiceImpl(17%)
> org.apache.shenyu.admin.service.register.ShenyuClientRegisterTarsServiceImpl(15%)
> org.apache.shenyu.admin.service.register.ShenyuClientRegisterDefaultServiceImpl(14%)
> org.apache.shenyu.admin.service.register.ShenyuClientRegisterMotanServiceImpl(18%)
> org.apache.shenyu.admin.service.register.ShenyuClientRegisterGrpcServiceImpl(18%)
> org.apache.shenyu.admin.listener.http.HttpLongPollingDataChangedListener(7%)
> org.apache.shenyu.admin.listener.http.HttpLongPollingDataChangedListener.DataChangeTask(0%)
> org.apache.shenyu.admin.listener.http.HttpLongPollingDataChangedListener.LongPollingClient(0%)
> org.apache.shenyu.admin.listener.AbstractDataChangedListener(3%)
> org.apache.shenyu.admin.listener.ConfigDataCache(0%)
> org.apache.shenyu.admin.listener.ConfigDataCache(0%)
> org.apache.shenyu.admin.listener.zookeeper.HttpServiceDiscovery(7%)
> org.apache.shenyu.admin.exception.ExceptionHandlers(18%)
> org.apache.shenyu.admin.config.LdapConfiguration(0%)
> org.apache.shenyu.admin.config.DataSyncConfiguration(0%)
> org.apache.shenyu.admin.config.ConsulServerConfiguration(0%)
> org.apache.shenyu.admin.config.DataBaseConfiguration(0%)
> org.apache.shenyu.admin.shiro.bean.StatelessAuthFilter(6%)
> org.apache.shenyu.admin.shiro.bean.StatelessToken(0%)
> org.apache.shenyu.admin.listener.websocket.WebsocketListener(10%)
> org.apache.shenyu.admin.listener.websocket.WebsocketConfigurator(28%)
> org.apache.shenyu.admin.shiro.config.ShiroRealm(0%)
> org.apache.shenyu.admin.disruptor.subscriber.URIRegisterExecutorSubscriber(12%)
> org.apache.shenyu.admin.disruptor.subscriber.MetadataExecutorSubscriber(60%)
> org.apache.shenyu.admin.aspect.DataPermissionAspect(8%)
>
> each line has record a class and the current test coverage is in the brackets
> at end of line.
>
> I post the statistic via the jacoco plugin in the maven test lifetime (you
> can use mvn test in your local repository, then you can get the result in
> maven generate target directory which named site/jacoco, the code coverage
> will be present in the static web page index.html).
>
> We hope more developer to participant to impove test coverage.