[jira] [Commented] (THRIFT-2814) args/result classes not found when no namespace is set

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205635#comment-14205635 ] 

ASF GitHub Bot commented on THRIFT-2814:
----------------------------------------

GitHub user Jens-G opened a pull request:

    https://github.com/apache/thrift/pull/261

    THRIFT-2814 args/results class not found without namespaces

    The args/results helper classes are not found by the Haxe compiler if no namespaces are set in the IDL
    
    Changes:
    - one source file per Haxe class
    - ensure correctly capitalized names

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Jens-G/thrift thrift-2814

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/261.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #261
    
----
commit fceae91c153c86e146259b3a44fe693d0e467d79
Author: Jens Geyer <je...@apache.org>
Date:   2014-11-09T22:05:37Z

    args/results class not found without namespaces
    - one source file per Haxe class
    - ensure correctly capitalized names

----


> args/result classes not found when no namespace is set
> ------------------------------------------------------
>
>                 Key: THRIFT-2814
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2814
>             Project: Thrift
>          Issue Type: Bug
>          Components: Haxe - Compiler
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>             Fix For: 0.9.3
>
>
> The args/results helper classes are not found by the Haxe compiler if no namespaces are set in the IDL. With Haxe, classes are located via: 
>   (1) the file name matching the class name 
>   (2) wildcard {{namespace.*}} imports. 
> With an empty namespace only the first method is used. Because the helper classes are located within the (e.g.) {{MethodCall_Impl.hx}} file instead the {{MethodCall_args.hx}} file, they are not found in that case. 
> Changes:
> - generate one source file per Haxe class
> - ensure correctly capitalized names in all cases



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)