[jira] [Comment Edited] (CASSANDRA-9656) Strong circular-reference leaks

["Benedict (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-9656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14614783#comment-14614783 ] 

Benedict edited comment on CASSANDRA-9656 at 7/6/15 10:07 AM:
--------------------------------------------------------------

So, it turns out I was clicking on the wrong cassci links, and there were a _number_ of small problems with this patch, particularly on the 2.1 branch:

* The new {{getCurrentVersion}} implementation in 2.1 was not accounting for shadowed files, nor files that had not been exposed to the DataTracker.
* The key cache was not being setup for all readers
* The book-keeping for totalDiskSpaceUsed was incorrect for _offline_ operations (this is totally benign, but was upsetting our unit tests)

I've pushed [2.1|https://github.com/belliottsmith/cassandra/tree/9656] and [2.2|https://github.com/belliottsmith/cassandra/tree/9656] fixes for review. [~blambov] or [~krummas] could somebody +1 them with some urgency? Thanks


was (Author: benedict):
So, it turns out I was clicking on the wrong cassci links, and there were a _number_ of small problems with this patch, particularly on the 2.1 branch:

* The new {{getCurrentVersion}} implementation in 2.1 was not accounting for shadowed files, nor files that had not been exposed to the DataTracker.
* The key cache was not being setup for all readers
* The book-keeping for totalDiskSpaceUsed was incorrect for _offline_ operations (this is totally benign, but was upsetting our unit tests)

I've pushed [2.1|https://github.com/belliottsmith/cassandra/tree/9656] and [2.2|https://github.com/belliottsmith/cassandra/tree/9656] fixes for review. [~blambov] or [~marcuse] could somebody +1 them with some urgency? Thanks

> Strong circular-reference leaks
> -------------------------------
>
>                 Key: CASSANDRA-9656
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9656
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Benedict
>            Assignee: Benedict
>            Priority: Critical
>             Fix For: 2.1.8
>
>
> As discussed in CASSANDRA-9423, we are leaking references to the ref-counted object into the Ref.Tidy, so that they remain strongly reachable, significantly limiting the value of the leak detection.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)