[GitHub] [solr] cpoerschke commented on a diff in pull request #947: SOLR-16300: migrate assert to non deprecated version

[GitBox <gi...@apache.org>]

cpoerschke commented on code in PR #947:
URL: https://github.com/apache/solr/pull/947#discussion_r924794097


##########
solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java:
##########
@@ -72,6 +74,11 @@
  */
 public class SolrCloudTestCase extends SolrTestCaseJ4 {
 
+
+  public static <T> void assertThat(T actual, Matcher<? super T> matcher) {

Review Comment:
   If having this, wondering about having it here in `SolrCloudTestCase` vs. in `SolrTestCaseJ4` vs. in `SolrTestCase` classes?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org