You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/07/31 22:25:20 UTC
[jira] [Commented] (CB-10067) Camera.PictureSourceType description
is not right for iOS
[ https://issues.apache.org/jira/browse/CB-10067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401374#comment-15401374 ]
ASF GitHub Bot commented on CB-10067:
-------------------------------------
GitHub user jcesarmobile opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/227
CB-10067: (ios) clarifications on PictureSourceType
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### What does this PR do?
Clarifications on PictureSourceType
### What testing has been done on this change?
### Checklist
- [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secretary@apache.org.
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jcesarmobile/cordova-plugin-camera CB-10067
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-camera/pull/227.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #227
----
commit d5a6e87ddfba183af2e6547f6ec6f4d523a159c5
Author: Julio César <jc...@gmail.com>
Date: 2016-07-31T22:23:01Z
CB-10067: (ios) clarifications on PictureSourceType
----
> Camera.PictureSourceType description is not right for iOS
> ---------------------------------------------------------
>
> Key: CB-10067
> URL: https://issues.apache.org/jira/browse/CB-10067
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Docs, Plugin Camera
> Environment: iOS
> Reporter: jcesarmobile
> Assignee: jcesarmobile
> Priority: Minor
> Labels: triaged
>
> Camera.PictureSourceType.PHOTOLIBRARY and Camera.PictureSourceType.SAVEDPHOTOALBUM have both the same description (Choose image from picture library ), but they are not se same
> Camera.PictureSourceType.PHOTOLIBRARY uses UIImagePickerControllerSourceTypePhotoLibrary, that references the entire photo library, letting the user choose the album he wants to use. Camera.PictureSourceType.SAVEDPHOTOALBUM uses UIImagePickerControllerSourceTypeSavedPhotosAlbum, that goes to the camera roll album and don't let to select another.
> We should make clear that they are different and explain why
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org