You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by michalklempa <gi...@git.apache.org> on 2016/02/18 09:51:02 UTC
[GitHub] nifi pull request: NIFI-1518 InferAvroSchema note has an option to...
GitHub user michalklempa opened a pull request:
https://github.com/apache/nifi/pull/235
NIFI-1518 InferAvroSchema note has an option to set CSV delimiter
Code transliterated from ConvertCSVToAvro processor, new Property DELIMITER (default ',') added.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michalklempa/nifi nifi-1518
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/235.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #235
----
commit ba90cdeab98ab529aa983ff448a5803aa5de0c96
Author: Michal Klempa <mi...@gmail.com>
Date: 2016-02-18T08:42:58Z
NIFI-1518 InferAvroSchema note has an option to set CSV delimiter
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1518 InferAvroSchema note has an option to...
Posted by trkurc <gi...@git.apache.org>.
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/235#issuecomment-185679941
reviewing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1518 InferAvroSchema note has an option to...
Posted by trkurc <gi...@git.apache.org>.
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/235#discussion_r53414564
--- Diff: nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/test/java/org/apache/nifi/processors/kite/TestInferAvroSchema.java ---
@@ -51,6 +51,7 @@ public void setup() {
runner.setProperty(InferAvroSchema.GET_CSV_HEADER_DEFINITION_FROM_INPUT, "true");
runner.setProperty(InferAvroSchema.SCHEMA_DESTINATION, InferAvroSchema.DESTINATION_CONTENT);
runner.setProperty(InferAvroSchema.HEADER_LINE_SKIP_COUNT, "0");
+ runner.setProperty(InferAvroSchema.DELIMITER, ",");
--- End diff --
do you object to leaving this line out to ensure correct "default" behavior?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1518 InferAvroSchema note has an option to...
Posted by trkurc <gi...@git.apache.org>.
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/235#issuecomment-195092832
@JPercivall - code looks good, just need to contrib-check, do some quick manual testing and merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1518 InferAvroSchema note has an option to...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/235
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1518 InferAvroSchema note has an option to...
Posted by michalklempa <gi...@git.apache.org>.
Github user michalklempa commented on a diff in the pull request:
https://github.com/apache/nifi/pull/235#discussion_r53425835
--- Diff: nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/test/java/org/apache/nifi/processors/kite/TestInferAvroSchema.java ---
@@ -51,6 +51,7 @@ public void setup() {
runner.setProperty(InferAvroSchema.GET_CSV_HEADER_DEFINITION_FROM_INPUT, "true");
runner.setProperty(InferAvroSchema.SCHEMA_DESTINATION, InferAvroSchema.DESTINATION_CONTENT);
runner.setProperty(InferAvroSchema.HEADER_LINE_SKIP_COUNT, "0");
+ runner.setProperty(InferAvroSchema.DELIMITER, ",");
--- End diff --
No.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1518 InferAvroSchema note has an option to...
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/235#issuecomment-195030029
@trkurc what was the result of your review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---