[isis] branch v2 updated: ISIS-2089: when recoverable error, stay on same page, don't redirect

[ah...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a commit to branch v2
in repository https://gitbox.apache.org/repos/asf/isis.git


The following commit(s) were added to refs/heads/v2 by this push:
     new 635f0bd  ISIS-2089: when recoverable error, stay on same page, don't redirect
635f0bd is described below

commit 635f0bd7c2223dfb94c5570215f7a0a0eb3dd2ff
Author: Andi Huber <ah...@apache.org>
AuthorDate: Fri Jan 18 16:51:51 2019 +0100

    ISIS-2089: when recoverable error, stay on same page, don't redirect
    
    Task-Url: https://issues.apache.org/jira/browse/ISIS-2089
---
 .../org/apache/isis/viewer/wicket/ui/panels/FormExecutorDefault.java | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/panels/FormExecutorDefault.java b/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/panels/FormExecutorDefault.java
index ddfdf4f..8daa1a0 100644
--- a/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/panels/FormExecutorDefault.java
+++ b/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/panels/FormExecutorDefault.java
@@ -238,6 +238,11 @@ implements FormExecutor {
                 // ... display as growl pop-up
                 final MessageBroker messageBroker = getAuthenticationSession().getMessageBroker();
                 messageBroker.setApplicationError(message);
+                
+                //TODO [2089] hotfix to render the error on the same page instead of redirecting;
+                // previous behavior was to fall through and rethrow, which lead to the error never shown
+                return false;
+                //--
             }
 
             // irrespective, capture error in the Command, and propagate